Skip to content

FallbackBatchErrorHandler may cause consumers to pause even if they are not retrying #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vooft opened this issue Aug 26, 2022 · 0 comments · Fixed by #2383
Closed

FallbackBatchErrorHandler may cause consumers to pause even if they are not retrying #2382

vooft opened this issue Aug 26, 2022 · 0 comments · Fixed by #2383
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. type: bug
Milestone
3.0.0-M6

Comments

@vooft
Copy link
Contributor

vooft commented Aug 26, 2022

In what version(s) of Spring for Apache Kafka are you seeing this issue?

For example:

2.8.8+

Describe the bug

Error handlers are shared between multiple consumers if concurrency > 1, which may result in pausing consumers if some others are retrying at the moment and rebalancing kicks in.
@vooft vooft mentioned this issue Aug 26, 2022
Merged
@garyrussell garyrussell added ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. and removed status: waiting-for-triage labels Aug 29, 2022
@garyrussell garyrussell added this to the 3.0.0-M6 milestone Aug 29, 2022
garyrussell added a commit that referenced this issue Aug 29, 2022
@garyrussell
GH-2382: Fix RetryingBatchErrorHandler Cross Talk
3de1e89 
Resolves #2382

Change `retrying` boolean to `ThreadLocal<Boolean>`.
garyrussell pushed a commit that referenced this issue Aug 29, 2022
@garyrussell
GH-2382: Fix FBEH Cross Talk
6a28cc5 
Remove sharing of the retrying field in FallbackBatchErrorHandler (#2383)

* Remove sharing of the retrying field in FallbackBatchErrorHandler

* Fix checkstyle
garyrussell added a commit that referenced this issue Aug 30, 2022
@garyrussell
GH-2382: Fix Unchecked Cast in Test
b6e6502
garyrussell added a commit that referenced this issue Aug 30, 2022
@garyrussell
GH-2382: Fix Unchecked Cast in Test
781e726
garyrussell added a commit that referenced this issue Aug 30, 2022
@garyrussell
GH-2382: Fix Unchecked Cast in Test
e1bb194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. type: bug
Projects
None yet
Milestone
3.0.0-M6
Development

Successfully merging a pull request may close this issue.

Remove sharing of the retrying field in FallbackBatchErrorHandler
2 participants
@vooft @garyrussell