Skip to content

Fix New Class Tangles in 3.0 #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Sep 28, 2022 · 0 comments
Closed

Fix New Class Tangles in 3.0 #2417

garyrussell opened this issue Sep 28, 2022 · 0 comments
Labels
type: task
Milestone
3.0.0-RC1

Comments

@garyrussell
Copy link
Contributor

Screen Shot 2022-09-28 at 4 38 16 PM

Screen Shot 2022-09-28 at 4 38 09 PM

Screen Shot 2022-09-28 at 4 37 55 PM
@garyrussell garyrussell added this to the 3.0.0-RC1 milestone Sep 28, 2022
@garyrussell garyrussell changed the title Fix New Package Tangles in 3.0 Fix New Class Tangles in 3.0 Sep 28, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
11ba09b 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
61a72aa 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
3858df7 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
e110ee7 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandler Events
66d950b 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
@garyrussell garyrussell mentioned this issue Sep 29, 2022
Merged
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2198: Observablility Documentation, Polish
b239709 
Refactor for latest snapshots; add documentation generation.

spring-projectsGH-2417: Fix class tangles.

Disable auto doc generation and polish manually.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2198: Observablility Documentation, Polish
6ede5e6 
Refactor for latest snapshots; add documentation generation.

spring-projectsGH-2417: Fix class tangles.

Resolves spring-projects#2417

Disable auto doc generation and polish manually.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2198: Observablility Documentation, Polish
998840e 
Refactor for latest snapshots; add documentation generation.
Use NOOP registry and supplier for context.

spring-projectsGH-2417: Fix class tangles.

Resolves spring-projects#2417

Disable auto doc generation and polish manually.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2198: Observablility Documentation, Polish
16f571a 
Refactor for latest snapshots; add documentation generation.
Use NOOP registry and supplier for context.

spring-projectsGH-2417: Fix class tangles.

Resolves spring-projects#2417

Disable auto doc generation and polish manually.
@garyrussell garyrussell mentioned this issue Sep 29, 2022
Closed
artembilan pushed a commit that referenced this issue Sep 29, 2022
@garyrussell @artembilan
GH-2387: Fix FallbackBatchErrorHandler Events
b0c1c98 
Resolves #2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in #2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Sep 29, 2022
@garyrussell @artembilan
GH-2387: Fix FallbackBatchErrorHandler Events
5c776cd 
Resolves #2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in #2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**

# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/listener/ErrorHandlingUtils.java
#	spring-kafka/src/test/java/org/springframework/kafka/listener/FallbackBatchErrorHandlerIntegrationTests.java
artembilan pushed a commit that referenced this issue Sep 29, 2022
@garyrussell @artembilan
GH-2387: Fix FallbackBatchErrorHandler Events
f6cbf11 
Resolves #2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in #2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**

# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/listener/ErrorHandlingUtils.java
#	spring-kafka/src/test/java/org/springframework/kafka/listener/FallbackBatchErrorHandlerIntegrationTests.java
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Oct 3, 2022
@garyrussell
spring-projectsGH-2198: Observablility Documentation, Polish
1a06ead 
Refactor for latest snapshots; add documentation generation.
Use NOOP registry and supplier for context.

spring-projectsGH-2417: Fix class tangles.

Resolves spring-projects#2417

Disable auto doc generation and polish manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-2198: Observability Documentation garyrussell/spring-kafka
1 participant
@garyrussell