Skip to content

Support Dynamic Micrometer Tags Based on Consumer/Producer Record #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Mar 22, 2023 Discussed in #2632 · 0 comments · Fixed by #2648
Closed

Support Dynamic Micrometer Tags Based on Consumer/Producer Record #2638

garyrussell opened this issue Mar 22, 2023 Discussed in #2632 · 0 comments · Fixed by #2648
Assignees
@garyrussell
Labels
backport 2.9.x (obsolete) type: enhancement
Milestone
3.0.6

Comments

@garyrussell
Copy link
Contributor

Discussed in #2632

Originally posted by erohana March 20, 2023
Hi,
i'm looking for a way to enrich the spring.kafka.listener metric with metadata from the consumer record.
basically, I'm looking for a way to do it like WebMvcTagsContributor

is there way to do this customization ?
@garyrussell garyrussell added this to the 3.0.6 milestone Mar 22, 2023
@garyrussell garyrussell self-assigned this Mar 22, 2023
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 30, 2023
@garyrussell
spring-projectsGH-2638: Add Dynamic Micrometer Tags
5380b1e 
Resolves spring-projects#2638

**cherry-pick to 2.9.x**

TODO: Support for Observations when `observationEnabled` (3.0.x only).
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 30, 2023
@garyrussell
spring-projectsGH-2638: Add Dynamic Micrometer Tags
1d4a008 
Resolves spring-projects#2638

**cherry-pick to 2.9.x**

TODO: Support for Observations when `observationEnabled` (3.0.x only).
@garyrussell garyrussell mentioned this issue Mar 30, 2023
Merged
@artembilan artembilan mentioned this issue Mar 30, 2023
Closed
artembilan pushed a commit that referenced this issue Mar 30, 2023
@garyrussell
GH-2638: Add Dynamic Micrometer Tags
0f8dc80 
* GH-2638: Add Dynamic Micrometer Tags

Resolves #2638

**cherry-pick to 2.9.x**

TODO: Support for Observations when `observationEnabled` (3.0.x only).

* Fix docs.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 30, 2023
@garyrussell
spring-projectsGH-2638: Support Dynamic Tags via Observation
2e9f7ee 
See spring-projects#2648
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Mar 30, 2023
@garyrussell
spring-projectsGH-2638: Support Dynamic Tags via Observation
fb01cd0 
See spring-projects#2648
artembilan pushed a commit that referenced this issue Mar 30, 2023
@garyrussell @artembilan
GH-2638: Add Dynamic Micrometer Tags
ad09ce3 
* GH-2638: Add Dynamic Micrometer Tags

Resolves #2638

**cherry-pick to 2.9.x**

TODO: Support for Observations when `observationEnabled` (3.0.x only).

* Fix docs.
# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/core/KafkaTemplate.java
#	spring-kafka/src/main/java/org/springframework/kafka/listener/ContainerProperties.java
#	spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
#	spring-kafka/src/main/java/org/springframework/kafka/support/micrometer/MicrometerHolder.java
artembilan pushed a commit that referenced this issue Mar 30, 2023
@garyrussell
GH-2638: Support Dynamic Tags via Observation
f351a7a 
See #2648
garyrussell added a commit that referenced this issue May 8, 2023
@garyrussell
GH-2638: Fix Deprecation Warnings in Tests
9619aba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
backport 2.9.x (obsolete) type: enhancement
Projects
None yet
Milestone
3.0.6
Development

Successfully merging a pull request may close this issue.

GH-2638: Add Dynamic Micrometer Tags garyrussell/spring-kafka
1 participant
@garyrussell