-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Invalid transition attempted from state IN_TRANSACTION to state IN_TRANSACTION after broker bounce #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this issue
Apr 23, 2018
Fixes spring-projects#661 I could not reproduce the problem that I reported in the issue; so, if any exception occurs on `beginTransaction()`, throw the exception to the caller after closing the producer and prevent its return to the cache. Also, reading the javadocs for `ProducerFencedException`, we should have been closing the producer if that exception occurred anyway. ``` /** * This fatal exception indicates that another producer with the same <code>transactional.id</code> has been * started. It is only possible to have one producer instance with a <code>transactional.id</code> at any * given time, and the latest one to be started "fences" the previous instances so that they can no longer * make transactional requests. When you encounter this exception, you must close the producer instance. */ ``` Cherry-pick to master, 2.0.x, 1.3.x.
garyrussell
added a commit
to garyrussell/spring-kafka
that referenced
this issue
Apr 23, 2018
Fixes spring-projects#661 I could not reproduce the problem that I reported in the issue; so, if any exception occurs on `beginTransaction()`, throw the exception to the caller after closing the producer and prevent its return to the cache. Also, reading the javadocs for `ProducerFencedException`, we should have been closing the producer if that exception occurred anyway. ``` /** * This fatal exception indicates that another producer with the same <code>transactional.id</code> has been * started. It is only possible to have one producer instance with a <code>transactional.id</code> at any * given time, and the latest one to be started "fences" the previous instances so that they can no longer * make transactional requests. When you encounter this exception, you must close the producer instance. */ ``` Cherry-pick to master, 2.0.x, 1.3.x.
artembilan
pushed a commit
that referenced
this issue
Apr 23, 2018
Fixes #661 I could not reproduce the problem that I reported in the issue; so, if any exception occurs on `beginTransaction()`, throw the exception to the caller after closing the producer and prevent its return to the cache. Also, reading the javadocs for `ProducerFencedException`, we should have been closing the producer if that exception occurred anyway. ``` /** * This fatal exception indicates that another producer with the same <code>transactional.id</code> has been * started. It is only possible to have one producer instance with a <code>transactional.id</code> at any * given time, and the latest one to be started "fences" the previous instances so that they can no longer * make transactional requests. When you encounter this exception, you must close the producer instance. */ ``` Cherry-pick to master, 2.0.x, 1.3.x.
artembilan
pushed a commit
that referenced
this issue
Apr 23, 2018
Fixes #661 I could not reproduce the problem that I reported in the issue; so, if any exception occurs on `beginTransaction()`, throw the exception to the caller after closing the producer and prevent its return to the cache. Also, reading the javadocs for `ProducerFencedException`, we should have been closing the producer if that exception occurred anyway. ``` /** * This fatal exception indicates that another producer with the same <code>transactional.id</code> has been * started. It is only possible to have one producer instance with a <code>transactional.id</code> at any * given time, and the latest one to be started "fences" the previous instances so that they can no longer * make transactional requests. When you encounter this exception, you must close the producer instance. */ ``` Cherry-pick to master, 2.0.x, 1.3.x.
artembilan
pushed a commit
that referenced
this issue
Apr 23, 2018
Fixes #661 I could not reproduce the problem that I reported in the issue; so, if any exception occurs on `beginTransaction()`, throw the exception to the caller after closing the producer and prevent its return to the cache. Also, reading the javadocs for `ProducerFencedException`, we should have been closing the producer if that exception occurred anyway. ``` /** * This fatal exception indicates that another producer with the same <code>transactional.id</code> has been * started. It is only possible to have one producer instance with a <code>transactional.id</code> at any * given time, and the latest one to be started "fences" the previous instances so that they can no longer * make transactional requests. When you encounter this exception, you must close the producer instance. */ ``` Cherry-pick to master, 2.0.x, 1.3.x. * Fix `DefaultKafkaProducerFactoryTests` for its Mockito version and don't use JUnit 5
denis554
added a commit
to denis554/spring-kafka
that referenced
this issue
Mar 27, 2019
Fixes spring-projects/spring-kafka#661 I could not reproduce the problem that I reported in the issue; so, if any exception occurs on `beginTransaction()`, throw the exception to the caller after closing the producer and prevent its return to the cache. Also, reading the javadocs for `ProducerFencedException`, we should have been closing the producer if that exception occurred anyway. ``` /** * This fatal exception indicates that another producer with the same <code>transactional.id</code> has been * started. It is only possible to have one producer instance with a <code>transactional.id</code> at any * given time, and the latest one to be started "fences" the previous instances so that they can no longer * make transactional requests. When you encounter this exception, you must close the producer instance. */ ``` Cherry-pick to master, 2.0.x, 1.3.x. (cherry picked from commit f48ad87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While testing #660 ...
I stopped the broker, hit enter, and restarted the broker.
After that, all subsequent POSTs got
The text was updated successfully, but these errors were encountered: