Clarify ExponentialBackOffPolicy maxDelay default #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomazfernandes
added a commit
to tomazfernandes/spring-kafka
that referenced
this pull request
Feb 24, 2022
The wording in `@BackOff`'s maxDelay property's javadoc is a bit ambiguous. Clarify its default behavior in the Retryable Topic's documentation.
tomazfernandes
force-pushed
the
GH-2137
branch
from
5f38594 to
9bd0319
Compare
The wording in `@BackOff`'s maxDelay property's javadoc is a bit ambiguous. Clarify its default behavior in the Retryable Topic's documentation.
garyrussell
approved these changes
Mar 1, 2022
garyrussell
pushed a commit
that referenced
this pull request
Mar 1, 2022
The wording in `@BackOff`'s maxDelay property's javadoc is a bit ambiguous. Clarify its default behavior in the Retryable Topic's documentation.
garyrussell
pushed a commit
that referenced
this pull request
Mar 1, 2022
The wording in `@BackOff`'s maxDelay property's javadoc is a bit ambiguous. Clarify its default behavior in the Retryable Topic's documentation.
|
...and cherry-picked to 2.8.x, 2.7.x |
|
Thanks, Tomaz - sorry we missed adding you as an author earlier. |
|
No worries @garyrussell, I'm the one to thank you for such an incredible opportunity! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-2137
The wording in
@BackOff's maxDelay property's javadoc is a bit ambiguous. Clarify its default behavior in the Retryable Topic's documentation. Also a few smalls adjustments around that.LMK if there's anything to change.
Thanks.