Skip to content

GH-2154: Fix Tombstones with Delegating Seriali... #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2019-2021 the original author or authors.
* Copyright 2019-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -74,6 +74,9 @@ public byte[] serialize(String topic, Object data) {
@SuppressWarnings("unchecked")
@Override
public byte[] serialize(String topic, Headers headers, Object data) {
if (data == null) {
return null;
}
return ((Serializer<Object>) findDelegate(topic)).serialize(topic, headers, data);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,18 @@ public void configure(Map<String, ?> configs, boolean isKey) {

@Override
public byte[] serialize(String topic, Object data) {
if (data == null) {
return null;
}
Serializer<Object> delegate = findDelegate(data, this.delegates);
return delegate.serialize(topic, data);
}

@Override
public byte[] serialize(String topic, Headers headers, Object data) {
if (data == null) {
return null;
}
Serializer<Object> delegate = findDelegate(data, this.delegates);
return delegate.serialize(topic, headers, data);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2019-2021 the original author or authors.
* Copyright 2019-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -190,6 +190,9 @@ public byte[] serialize(String topic, Object data) {

@Override
public byte[] serialize(String topic, Headers headers, Object data) {
if (data == null) {
return null;
}
byte[] value = null;
String selectorKey = selectorKey();
Header header = headers.lastHeader(selectorKey);
Expand Down