GH-2195: Fix No Seek Retry Mode #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
May 9, 2022
| */ | ||
| @SpringJUnitConfig | ||
| @DirtiesContext | ||
| public class DefaultErrorHandlerSeekAfterCommitException { |
There was a problem hiding this comment.
Suggested change
| public class DefaultErrorHandlerSeekAfterCommitException { | |
| public class DefaultErrorHandlerSeekAfterCommitExceptionTests { |
?
| */ | ||
| @SpringJUnitConfig | ||
| @DirtiesContext | ||
| public class DefaultErrorHandlerSeekAfterCommitExceptionBatchAck { |
There was a problem hiding this comment.
Was the Tests suffix rule changed somehow?
- Revert to seeking when `CommitFailedException` - due to a rebalance - For batch listeners, move committing to the try block - For record listeners, `AckMode.RECORD` already commits in the try block - With `AckMode.BATCH`, detect a no-seek retry and call the error handler `handleRemaining` **cherry-pick to 2.9.x**
artembilan
pushed a commit
that referenced
this pull request
Jun 15, 2022
Related to: #2195 - Revert to seeking when `CommitFailedException` - due to a rebalance - For batch listeners, move committing to the try block - For record listeners, `AckMode.RECORD` already commits in the try block - With `AckMode.BATCH`, detect a no-seek retry and call the error handler `handleRemaining` **cherry-pick to 2.9.x** * Fix test class names.
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommitFailedException- due to a rebalanceAckMode.RECORDalready commits in the try blockAckMode.BATCH, detect a no-seek retry and call the error handlerhandleRemainingcherry-pick to 2.9.x