Skip to content

GH-2295: No Resolvers with ConsumerRecordMetadata #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

garyrussell
Copy link
Contributor

Resolves #2295

A subclass of InvocableHandlerMethod was used to signal that a method
needs a ConsumerRecordMetadata to be constructed.

However, the constructor that takes an existing IHM, does not fully clone
the argument passed into it.

Then, the payload resolver was not invoked to resolve that parameter.

Use a map of booleans instead, to signal the creation of the metadata.

cherry-pick to 2.9.x, 2.8.x, 2.7.x

Resolves spring-projects#2295

A subclass of `InvocableHandlerMethod` was used to signal that a method
needs a `ConsumerRecordMetadata` to be constructed.

However, the constructor that takes an existing IHM, does not fully clone
the argument passed into it.

Then, the payload resolver was not invoked to resolve that parameter.

Use a map of booleans instead, to signal the creation of the metadata.

**cherry-pick to 2.9.x, 2.8.x, 2.7.x**
@artembilan artembilan merged commit 4d4a1a6 into spring-projects:main Jun 6, 2022
@artembilan
Copy link
Member

artembilan commented Jun 6, 2022

... and cherry-picked to all mentioned supported versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The addition of a parameter of type ConsumerRecordMetaData breaks a working setup
2 participants