Skip to content

Update DLT log message and docs #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bky373
Copy link
Contributor

@bky373 bky373 commented Dec 2, 2024

Changes

  • DeadLetterPublishingRecoverer.java
    • The field failIfNoDestinationReturned is non-existent. Moreover, in the context of DLT strategy here, fail means ending without performing any retry or throwing an error. However, failIfNoDestinationReturned: true actually throws an error, which is inconsistent with this meaning. Therefore, I changed it to throwIfNoDestinationReturned for clarity and consistency.
  • dlt-strategies.adoc
    • Modified the method signature for the @DltHandler annotation because it cannot be identical to the method signature for the @RetryableTopic annotation.
  • features.adoc
    • Removed the reference to kafkaOperations as it is a non-existent variable.

@sobychacko sobychacko added this to the 3.3.1 milestone Dec 3, 2024
@sobychacko sobychacko merged commit eca3750 into spring-projects:main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants