Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3693: Remove outdated DLT Topic Suffix references from Javadoc, re… #3831

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-3693: Remove outdated DLT Topic Suffix references from Javadoc, re… #3831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/sample-01/src/main/java/com/example/Application.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public void listen(Foo2 foo) {
this.exec.execute(() -> System.out.println("Hit Enter to terminate..."));
}

@KafkaListener(id = "dltGroup", topics = "topic1.DLT")
@KafkaListener(id = "dltGroup", topics = "topic1-dlt")
public void dltListen(byte[] in) {
logger.info("Received from DLT: " + new String(in));
this.exec.execute(() -> System.out.println("Hit Enter to terminate..."));
Expand All @@ -92,7 +92,7 @@ public NewTopic topic() {

@Bean
public NewTopic dlt() {
return new NewTopic("topic1.DLT", 1, (short) 1);
return new NewTopic("topic1-dlt", 1, (short) 1);
}

@Bean
Expand Down
2 changes: 1 addition & 1 deletion ...ka-docs/src/main/antora/modules/ROOT/pages/kafka/annotation-error-handling.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ public ErrorHandler eh(KafkaOperations<String, String> template) {
retries.value()[0]++;
}
return retries.value()[0] > 5
? new TopicPartition("topic.DLT", rec.partition())
? new TopicPartition("topic-dlt", rec.partition())
: new TopicPartition("topic", rec.partition());
}), new FixedBackOff(0L, 0L));
}
Expand Down
4 changes: 2 additions & 2 deletions ...kafka/src/main/java/org/springframework/kafka/listener/DeadLetterPublishingRecoverer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public class DeadLetterPublishingRecoverer extends ExceptionClassifier implement

/**
* Create an instance with the provided template and a default destination resolving
* function that returns a TopicPartition based on the original topic (appended with ".DLT")
* function that returns a TopicPartition based on the original topic (appended with "-dlt")
* from the failed record, and the same partition as the failed record. Therefore the
* dead-letter topic must have at least as many partitions as the original topic.
* @param template the {@link KafkaOperations} to use for publishing.
Expand All @@ -165,7 +165,7 @@ public DeadLetterPublishingRecoverer(KafkaOperations<? extends Object, ? extends
/**
* Create an instance with the provided templates and a default destination resolving
* function that returns a TopicPartition based on the original topic (appended with
* ".DLT") from the failed record, and the same partition as the failed record.
* "-dlt") from the failed record, and the same partition as the failed record.
* Therefore the dead-letter topic must have at least as many partitions as the
* original topic. The templates map keys are classes and the value the corresponding
* template to use for objects (producer record values) of that type. A
Expand Down