-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Introduce share consumer factories for Kafka Queues (Early Access) #3923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sobychacko
wants to merge
1
commit into
spring-projects:main
Choose a base branch
from
sobychacko:shared-consumer-iteration-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
351 changes: 351 additions & 0 deletions
351
spring-kafka/src/main/java/org/springframework/kafka/core/DefaultShareConsumerFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,351 @@ | ||
/* | ||
* Copyright 2025-2025 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.kafka.core; | ||
|
||
import java.time.Duration; | ||
import java.util.ArrayList; | ||
import java.util.Collections; | ||
import java.util.HashMap; | ||
import java.util.Iterator; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.concurrent.ConcurrentHashMap; | ||
import java.util.function.Supplier; | ||
|
||
import org.apache.kafka.clients.consumer.KafkaShareConsumer; | ||
import org.apache.kafka.clients.consumer.ShareConsumer; | ||
import org.apache.kafka.common.MetricName; | ||
import org.apache.kafka.common.serialization.Deserializer; | ||
import org.jspecify.annotations.Nullable; | ||
|
||
import org.springframework.beans.factory.BeanNameAware; | ||
import org.springframework.util.Assert; | ||
|
||
/** | ||
* The {@link ShareConsumerFactory} implementation to produce new {@link ShareConsumer} instances | ||
* for provided {@link Map} {@code configs} and optional {@link Deserializer}s on each | ||
* {@link #createShareConsumer(String, String, String)} invocation. | ||
* <p> | ||
* If you are using {@link Deserializer}s that have no-arg constructors and require no setup, then simplest to | ||
* specify {@link Deserializer} classes in the configs passed to the | ||
* {@link DefaultShareConsumerFactory} constructor. | ||
* <p> | ||
* If that is not possible, but you are using {@link Deserializer}s that may be shared between all {@link ShareConsumer} | ||
* instances (and specifically that their close() method is a no-op), then you can pass in {@link Deserializer} | ||
* instances for one or both of the key and value deserializers. | ||
* <p> | ||
* If neither of the above is true then you may provide a {@link Supplier} for one or both {@link Deserializer}s | ||
* which will be used to obtain {@link Deserializer}(s) each time a {@link ShareConsumer} is created by the factory. | ||
* | ||
* @param <K> the key type. | ||
* @param <V> the value type. | ||
* | ||
* @author Soby Chacko | ||
* @since 4.0 | ||
*/ | ||
public class DefaultShareConsumerFactory<K, V> extends KafkaResourceFactory | ||
implements ShareConsumerFactory<K, V>, BeanNameAware { | ||
|
||
private final Map<String, Object> configs; | ||
|
||
private @Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier; | ||
|
||
private @Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier; | ||
|
||
private boolean configureDeserializers = true; | ||
|
||
private final List<Listener<K, V>> listeners = new ArrayList<>(); | ||
|
||
private String beanName = "not.managed.by.Spring"; | ||
|
||
/** | ||
* Construct a factory with the provided configuration. | ||
* @param configs the configuration. | ||
*/ | ||
public DefaultShareConsumerFactory(Map<String, Object> configs) { | ||
this(configs, null, null); | ||
} | ||
|
||
/** | ||
* Construct a factory with the provided configuration and deserializer suppliers. | ||
* When the suppliers are invoked to get an instance, the deserializers' | ||
* {@code configure()} methods will be called with the configuration map. | ||
* @param configs the configuration. | ||
* @param keyDeserializerSupplier the key {@link Deserializer} supplier function (nullable). | ||
* @param valueDeserializerSupplier the value {@link Deserializer} supplier function (nullable). | ||
*/ | ||
public DefaultShareConsumerFactory(Map<String, Object> configs, | ||
@Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier, | ||
@Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier) { | ||
this(configs, keyDeserializerSupplier, valueDeserializerSupplier, true); | ||
} | ||
|
||
/** | ||
* Construct a factory with the provided configuration and deserializers. | ||
* The deserializers' {@code configure()} methods will be called with the | ||
* configuration map unless {@code configureDeserializers} is false. | ||
* @param configs the configuration. | ||
* @param keyDeserializer the key {@link Deserializer}. | ||
* @param valueDeserializer the value {@link Deserializer}. | ||
* @param configureDeserializers false to not configure the deserializers. | ||
*/ | ||
public DefaultShareConsumerFactory(Map<String, Object> configs, | ||
@Nullable Deserializer<K> keyDeserializer, | ||
@Nullable Deserializer<V> valueDeserializer, boolean configureDeserializers) { | ||
this(configs, keyDeserializer != null ? () -> keyDeserializer : null, | ||
valueDeserializer != null ? () -> valueDeserializer : null, configureDeserializers); | ||
} | ||
|
||
/** | ||
* Construct a factory with the provided configuration, deserializer suppliers, and deserializer config flag. | ||
* When the suppliers are invoked to get an instance, the deserializers' | ||
* {@code configure()} methods will be called with the configuration map unless | ||
* {@code configureDeserializers} is false. | ||
* @param configs the configuration. | ||
* @param keyDeserializerSupplier the key {@link Deserializer} supplier function (nullable). | ||
* @param valueDeserializerSupplier the value {@link Deserializer} supplier function (nullable). | ||
* @param configureDeserializers whether to configure deserializers. | ||
*/ | ||
public DefaultShareConsumerFactory(Map<String, Object> configs, | ||
@Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier, | ||
@Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier, | ||
boolean configureDeserializers) { | ||
this.configs = new ConcurrentHashMap<>(configs); | ||
this.configureDeserializers = configureDeserializers; | ||
this.keyDeserializerSupplier = keyDeserializerSupplier; | ||
this.valueDeserializerSupplier = valueDeserializerSupplier; | ||
} | ||
|
||
@Override | ||
public ShareConsumer<K, V> createShareConsumer(@Nullable String groupId, @Nullable String clientIdPrefix, | ||
@Nullable String clientIdSuffix) { | ||
return createRawConsumer(groupId, clientIdPrefix, clientIdSuffix); | ||
} | ||
|
||
/** | ||
* Create a {@link ShareConsumer}. | ||
* By default, this method returns an internal {@link ExtendedShareConsumer} | ||
* which is aware of provided listeners, therefore it is recommended | ||
* to extend that class if listeners are still involved for a custom {@link ShareConsumer}. | ||
* @param groupId the group id. | ||
* @param clientIdPrefix the client id prefix. | ||
* @param clientIdSuffix the client id suffix. | ||
* @return the consumer. | ||
*/ | ||
protected ShareConsumer<K, V> createRawConsumer(@Nullable String groupId, @Nullable String clientIdPrefix, | ||
@Nullable String clientIdSuffix) { | ||
Map<String, Object> consumerProperties = new HashMap<>(this.configs); | ||
if (groupId != null) { | ||
consumerProperties.put("group.id", groupId); | ||
} | ||
return new ExtendedShareConsumer(consumerProperties); | ||
} | ||
|
||
@Override | ||
public void setBeanName(String name) { | ||
this.beanName = name; | ||
} | ||
|
||
/** | ||
* Set the key deserializer. The deserializer will be configured using the consumer | ||
* configuration, unless {@link #setConfigureDeserializers(boolean) | ||
* configureDeserializers} is false. | ||
* @param keyDeserializer the deserializer. | ||
*/ | ||
public void setKeyDeserializer(@Nullable Deserializer<K> keyDeserializer) { | ||
this.keyDeserializerSupplier = () -> keyDeserializer; | ||
} | ||
|
||
/** | ||
* Set the value deserializer. The deserializer will be configured using the consumer | ||
* configuration, unless {@link #setConfigureDeserializers(boolean) | ||
* configureDeserializers} is false. | ||
* @param valueDeserializer the value deserializer. | ||
*/ | ||
public void setValueDeserializer(@Nullable Deserializer<V> valueDeserializer) { | ||
this.valueDeserializerSupplier = () -> valueDeserializer; | ||
} | ||
|
||
@Override | ||
@Nullable | ||
public Deserializer<K> getKeyDeserializer() { | ||
return this.keyDeserializerSupplier != null ? this.keyDeserializerSupplier.get() : null; | ||
} | ||
|
||
@Override | ||
@Nullable | ||
public Deserializer<V> getValueDeserializer() { | ||
return this.valueDeserializerSupplier != null ? this.valueDeserializerSupplier.get() : null; | ||
} | ||
|
||
/** | ||
* Set a supplier to supply instances of the key deserializer. The deserializer will | ||
* be configured using the consumer configuration, unless | ||
* {@link #setConfigureDeserializers(boolean) configureDeserializers} is false. | ||
* @param keyDeserializerSupplier the supplier (nullable). | ||
*/ | ||
public void setKeyDeserializerSupplier(@Nullable Supplier<@Nullable Deserializer<K>> keyDeserializerSupplier) { | ||
this.keyDeserializerSupplier = keyDeserializerSupplier; | ||
} | ||
|
||
/** | ||
* Set a supplier to supply instances of the value deserializer. The deserializer will | ||
* be configured using the consumer configuration, unless | ||
* {@link #setConfigureDeserializers(boolean) configureDeserializers} is false. | ||
* @param valueDeserializerSupplier the supplier (nullable). | ||
*/ | ||
public void setValueDeserializerSupplier(@Nullable Supplier<@Nullable Deserializer<V>> valueDeserializerSupplier) { | ||
this.valueDeserializerSupplier = valueDeserializerSupplier; | ||
} | ||
|
||
/** | ||
* Set to false (default true) to prevent programmatically provided deserializers (via | ||
* constructor or setters) from being configured using the consumer configuration, | ||
* e.g. if the deserializers are already fully configured. | ||
* @param configureDeserializers false to not configure. | ||
* @see #setKeyDeserializer(Deserializer) | ||
* @see #setKeyDeserializerSupplier(Supplier) | ||
* @see #setValueDeserializer(Deserializer) | ||
* @see #setValueDeserializerSupplier(Supplier) | ||
**/ | ||
public void setConfigureDeserializers(boolean configureDeserializers) { | ||
this.configureDeserializers = configureDeserializers; | ||
} | ||
|
||
/** | ||
* Return whether deserializers are configured automatically. | ||
* @return true if deserializers are configured automatically | ||
*/ | ||
public boolean isConfigureDeserializers() { | ||
return this.configureDeserializers; | ||
} | ||
|
||
/** | ||
* Get the current list of listeners. | ||
* @return the listeners. | ||
*/ | ||
@Override | ||
public List<Listener<K, V>> getListeners() { | ||
return Collections.unmodifiableList(this.listeners); | ||
} | ||
|
||
/** | ||
* Add a listener. | ||
* @param listener the listener. | ||
*/ | ||
@Override | ||
public void addListener(Listener<K, V> listener) { | ||
Assert.notNull(listener, "'listener' cannot be null"); | ||
this.listeners.add(listener); | ||
} | ||
|
||
/** | ||
* Add a listener at a specific index. | ||
* @param index the index (list position). | ||
* @param listener the listener. | ||
*/ | ||
@Override | ||
public void addListener(int index, Listener<K, V> listener) { | ||
Assert.notNull(listener, "'listener' cannot be null"); | ||
if (index >= this.listeners.size()) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's explain this logic in the JavaDocs! Some one might complain why we don't have |
||
this.listeners.add(listener); | ||
} | ||
else { | ||
this.listeners.add(index, listener); | ||
} | ||
} | ||
|
||
/** | ||
* Remove a listener. | ||
* @param listener the listener. | ||
* @return true if removed. | ||
*/ | ||
@Override | ||
public boolean removeListener(Listener<K, V> listener) { | ||
return this.listeners.remove(listener); | ||
} | ||
|
||
@Nullable | ||
private Deserializer<K> keyDeserializer(Map<String, Object> configs) { | ||
Deserializer<K> deserializer = | ||
this.keyDeserializerSupplier != null | ||
? this.keyDeserializerSupplier.get() | ||
: null; | ||
if (deserializer != null && this.configureDeserializers) { | ||
deserializer.configure(configs, true); | ||
} | ||
return deserializer; | ||
} | ||
|
||
@Nullable | ||
private Deserializer<V> valueDeserializer(Map<String, Object> configs) { | ||
Deserializer<V> deserializer = | ||
this.valueDeserializerSupplier != null | ||
? this.valueDeserializerSupplier.get() | ||
: null; | ||
if (deserializer != null && this.configureDeserializers) { | ||
deserializer.configure(configs, false); | ||
} | ||
return deserializer; | ||
} | ||
|
||
@Override | ||
public Map<String, Object> getConfigurationProperties() { | ||
return Collections.unmodifiableMap(this.configs); | ||
} | ||
|
||
protected class ExtendedShareConsumer extends KafkaShareConsumer<K, V> { | ||
|
||
private @Nullable String idForListeners; | ||
|
||
protected ExtendedShareConsumer(Map<String, Object> configProps) { | ||
super(configProps, keyDeserializer(configProps), valueDeserializer(configProps)); | ||
|
||
if (!DefaultShareConsumerFactory.this.listeners.isEmpty()) { | ||
Iterator<MetricName> metricIterator = metrics().keySet().iterator(); | ||
String clientId = "unknown"; | ||
if (metricIterator.hasNext()) { | ||
clientId = metricIterator.next().tags().get("client-id"); | ||
} | ||
this.idForListeners = DefaultShareConsumerFactory.this.beanName + "." + clientId; | ||
for (Listener<K, V> listener : DefaultShareConsumerFactory.this.listeners) { | ||
listener.consumerAdded(this.idForListeners, this); | ||
} | ||
} | ||
} | ||
|
||
@Override | ||
public void close() { | ||
super.close(); | ||
notifyConsumerRemoved(); | ||
} | ||
|
||
@Override | ||
public void close(Duration timeout) { | ||
super.close(timeout); | ||
notifyConsumerRemoved(); | ||
} | ||
|
||
private void notifyConsumerRemoved() { | ||
for (Listener<K, V> listener : DefaultShareConsumerFactory.this.listeners) { | ||
listener.consumerRemoved(this.idForListeners, this); | ||
} | ||
} | ||
|
||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this method to be exposed?