Skip to content

GH-652: JsonSerializer add null check for Headers #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

garyrussell
Copy link
Contributor

@garyrussell garyrussell commented Apr 18, 2018

Fixes #652

Kafka Streams ChangedSerializer calls the Serde with null in headers.

cherry-pick to 2.1.x, 2.0.x, 1.3.x

Fixes: spring-projects#652

Kafka Streams `ChangedSerializer` calls the `Serde` with `null` in `headers`.

**cherry-pick to 2.1.x, 2.0.x, 1.3.x**
@artembilan artembilan merged commit ad28b91 into spring-projects:master Apr 18, 2018
@artembilan
Copy link
Member

... and cherry-picked to 2.1.x.

I'm afraid we can't back-port this to 2.0.x and 1.3.x: the JsonSerializer implements ExtendedSerializer<T> exactly since 2.1.0: #492

@garyrussell
Copy link
Contributor Author

I'm afraid

Nothing to be afraid of 😄 - it means the problem doesn't exist in those versions 😄

@garyrussell garyrussell deleted the GH-652 branch November 7, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants