Skip to content

GH-666: Refactor KafkaEmbedded to expose admin and addTopics() #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2018
Merged

GH-666: Refactor KafkaEmbedded to expose admin and addTopics() #671

merged 1 commit into from
May 7, 2018
+84 −9

Conversation

garyrussell
Copy link
Contributor

Resolves #666

Allow a single KafkaEmbedded to be used across multiple test classes.

artembilan
artembilan requested changes May 4, 2018
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you don't stop such a thread-local Kafka instance.

Am I missing anything ?

@garyrussell
Copy link
Contributor Author

No; you are not missing anything; there are no hooks; the broker only stops when the test JVM shuts down

@garyrussell
Copy link
Contributor Author

Maybe we should just do the refactoring (addTopics()) and not institutionalize the holder, but the refactoring would allow users to do it if they understand the limitations.

@artembilan
Copy link
Member

That's going to be a middle ground, Gary.
I also thought why we don't provide addTopics() API there...
😄

@garyrussell garyrussell changed the title GH-666: Add KafkaEmbeddedHolder GH-666: Refactor KafkaEmbedded to expose admin and addTopics() May 5, 2018
@garyrussell
Copy link
Contributor Author

cherry-pick to 2.1

@garyrussell
spring-projectsGH-666: KafkaEmbedded doWithAdmin, addTopics
16d8dae 
Resolves spring-projects#666

Allow arbitrary `AdminClient` operations and adding topics.

Polishing - PR Comments
@artembilan artembilan merged commit be073a8 into spring-projects:master May 7, 2018
@artembilan
Copy link
Member

... and cherry-picked to 2.1.x.

@garyrussell garyrussell deleted the GH-666 branch June 21, 2018 15:27
@garyrussell garyrussell mentioned this pull request Jun 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyrussell @artembilan