Skip to content

Add proximity filter ~= #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkobel
Copy link

@mkobel mkobel commented Mar 19, 2025

Implement proximity filter to allow to create criteria queries like where("cn").proximity("John") resulting in a filter like (cn~=John)

@mkobel mkobel force-pushed the implement-proximity-filter branch from f768265 to c1c01f9 Compare March 19, 2025 16:06
@jzheaux jzheaux self-assigned this Apr 9, 2025
Copy link
Collaborator

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @mkobel! I appreciate this idea; I've left the rest of my feedback inline.

@mkobel mkobel force-pushed the implement-proximity-filter branch 2 times, most recently from 335edd9 to 456efde Compare April 9, 2025 21:59
@mkobel
Copy link
Author

mkobel commented Apr 9, 2025

Thanks for the PR, @mkobel! I appreciate this idea; I've left the rest of my feedback inline.

@jzheaux Thank you for the feedback. I rebased the changes. I hope they are as expected.

@mkobel mkobel requested a review from jzheaux April 9, 2025 23:37
@jzheaux jzheaux added this to the 3.3.0-RC1 milestone Apr 10, 2025
@jzheaux
Copy link
Collaborator

jzheaux commented Apr 10, 2025

@mkobel, thanks for the quick turnaround! Will you please do the following two polishes to wrap up:

  1. To your JavaDoc, add @since 3.3 to any new public methods or classes
  2. Locally run ./gradlew format && ./gradlew check

Signed-off-by: Moritz Kobel <[email protected]>
@mkobel mkobel force-pushed the implement-proximity-filter branch from 456efde to b4b2b51 Compare April 10, 2025 21:42
@mkobel
Copy link
Author

mkobel commented Apr 10, 2025

@mkobel, thanks for the quick turnaround! Will you please do the following two polishes to wrap up:

  1. To your JavaDoc, add @since 3.3 to any new public methods or classes
  2. Locally run ./gradlew format && ./gradlew check

@jzheaux Thank you for the feedback.
Sorry, I missed the tests after the last change. I now had to remove the equals test in ProximityFilterTests as the EqualsTester requires a subclass, which is not possible due to the final ProximityFilter. I hope this OK for you.

@jzheaux jzheaux changed the title Implement proximity filter ~= Add proximity filter ~= Apr 11, 2025
Copy link
Collaborator

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mkobel! I'll see about adding some additional tests in a polish commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants