Build using openjdk8 #550
Build using openjdk8 #550
Conversation
| @@ -2,7 +2,7 @@ | |||
| task downloadJavacc { | |||
| ext.file = "javacc-5.0.tar.gz" | |||
| ext.dest = file("$buildDir/javacc/$file") | |||
| ext.url = "https://javacc.org/downloads/$file" | |||
| ext.url = "http://download.openpkg.org/components/cache/javacc/$file" | |||
There was a problem hiding this comment.
Is there a reason that this was updated for using openjdk8? If we do this we'd like this to be a URL that works over https.
There was a problem hiding this comment.
No reason with openjdk8.
It is another issue with the gradle build (last successful build was 1 year ago).
I didn't find an URL over https which serve javacc-5.0.tar.gz (i don"t know why this version does not exist on the new javacc download page https://github.com/javacc/javacc/releases)
There was a problem hiding this comment.
Let's split this up into another PR. The openjdk8 is a no brainer. It appears due to this not being available over https, javacc may take a bit more work.
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-all.zip |
There was a problem hiding this comment.
Good catch here. I'd prefer things to be distinct commits so I went ahead and pushed a separate commit to fix this.
|
Thanks for the Pull Request! This is now merged into master via 50dae66 😄 |
see comment