Skip to content

Add support for SpEL topics on @PulsarMessage #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onobc opened this issue Feb 8, 2024 · 0 comments
Closed

Add support for SpEL topics on @PulsarMessage #568

onobc opened this issue Feb 8, 2024 · 0 comments
Labels
type: feature A new feature or enhacement
Milestone

Comments

@onobc
Copy link
Collaborator

onobc commented Feb 8, 2024

Allow users to specify topic information on @PulsarMessage using SpEL expressions.
This will bring @PulsarMessage topic info in feature parity w/ @PulsarListener, @PulsarReader, and @ReactivePulsarListener.

@jonasgeiregat here is the code that is used by the PulsarListener for this. It may be a good time to factor this common code out as these "resolveXYZ" functions are used in the annotation post processor for @Reactive/PulsarListener/Reader.

Originally posted by @jonasgeiregat in #565 (comment)

@onobc onobc added the type: feature A new feature or enhacement label Feb 8, 2024
@onobc onobc added this to the 1.1.0 milestone Feb 8, 2024
onobc added a commit to onobc/spring-pulsar that referenced this issue Feb 14, 2024

Verified

This commit was signed with the committer’s verified signature.
blacelle Benoit Chatain Lacelle
This commit adds a lightweight integration test nested in the
DefaultTopicResolverTests which uses a small Spring context to verify
actual expression evaluation.

See spring-projects#568
onobc added a commit to onobc/spring-pulsar that referenced this issue Feb 14, 2024

Verified

This commit was signed with the committer’s verified signature.
blacelle Benoit Chatain Lacelle
This commit adds a lightweight integration test nested in the
DefaultTopicResolverTests which uses a small Spring context to verify
actual expression evaluation.

See spring-projects#568
@onobc onobc closed this as completed in 18378a8 Feb 14, 2024
onobc added a commit that referenced this issue Feb 14, 2024
This commit adds a lightweight integration test nested in the
DefaultTopicResolverTests which uses a small Spring context to verify
actual expression evaluation.

See #568
@onobc onobc modified the milestones: 1.1.0, 1.1.0-M1 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature or enhacement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant