Skip to content

AuthenticationFailureEvent does not exist #10062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitrilc opened this issue Jul 12, 2021 · 2 comments · Fixed by #10064
Closed

AuthenticationFailureEvent does not exist #10062

dmitrilc opened this issue Jul 12, 2021 · 2 comments · Fixed by #10064
Assignees
@dmitrilc
Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug

Comments

@dmitrilc
Copy link
Contributor

dmitrilc commented Jul 12, 2021 •
edited
Loading

Describe the bug
The Spring Security doc, section 10.21 and 12.3.26 references AuthenticationFailureEvent, but it does not exist.

Looks like the class to be injected is AbstractAuthenticationFailureEvent instead.

The side-by-side Kotlin code example uses the correct AbstractAuthenticationFailureEvent class, while the Java version, throughout the doc, references the non-existent AuthenticationFailureEvent several times.

A. https://github.com/spring-projects/spring-security/blob/006b9b960797d279b31cf8c8d16f1549c5632b2c/docs/manual/src/docs/asciidoc/_includes/servlet/authentication/events.adoc

B. https://github.com/spring-projects/spring-security/blob/e30b45c6fbf99ccef774b40fa0aad57a97df41b0/docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc

To Reproduce
Go to https://docs.spring.io/spring-security/site/docs/current/reference/html5/#servlet-events

Expected behavior
The doc should mention AbstractAuthenticationFailureEvent instead.
@dmitrilc dmitrilc added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Jul 12, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jul 12, 2021

Thanks, @dmitrilc, for the report. Are you able to submit a PR to fix the documentation?

@jzheaux jzheaux closed this as completed Jul 12, 2021
@jzheaux jzheaux reopened this Jul 12, 2021
@jzheaux jzheaux added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 12, 2021
@dmitrilc dmitrilc mentioned this issue Jul 12, 2021
Merged
@dmitrilc
Copy link
Contributor Author

Hi. I created PR #10064

dmitrilc added a commit to dmitrilc/spring-security that referenced this issue Jul 13, 2021
@dmitrilc
Update oauth2-resourceserver.adoc
352360d 
fix the name of the parameter, from failure to badCredentials

Replaces AuthenticationFailureEvent

Remove AuthenticationFailureEvent Reference

Closes spring-projectsgh-10062
jzheaux pushed a commit that referenced this issue Jul 16, 2021
@dmitrilc @jzheaux
Update oauth2-resourceserver.adoc
a443126 
fix the name of the parameter, from failure to badCredentials

Replaces AuthenticationFailureEvent

Remove AuthenticationFailureEvent Reference

Closes gh-10062
jzheaux pushed a commit that referenced this issue Jul 16, 2021
@dmitrilc @jzheaux
Update oauth2-resourceserver.adoc
7abaefd 
fix the name of the parameter, from failure to badCredentials

Replaces AuthenticationFailureEvent

Remove AuthenticationFailureEvent Reference

Closes gh-10062
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Jul 16, 2021
Closed
jzheaux pushed a commit that referenced this issue Jul 16, 2021
@dmitrilc @jzheaux
Update oauth2-resourceserver.adoc
6878ff7 
fix the name of the parameter, from failure to badCredentials

Replaces AuthenticationFailureEvent

Remove AuthenticationFailureEvent Reference

Closes gh-10062
Closed
jzheaux pushed a commit that referenced this issue Jul 16, 2021
@dmitrilc @jzheaux
Update oauth2-resourceserver.adoc
1cf377c 
fix the name of the parameter, from failure to badCredentials

Replaces AuthenticationFailureEvent

Remove AuthenticationFailureEvent Reference

Closes gh-10062
Closed
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@dmitrilc
Update oauth2-resourceserver.adoc
8fb4d4e 
fix the name of the parameter, from failure to badCredentials

Replaces AuthenticationFailureEvent

Remove AuthenticationFailureEvent Reference

Closes spring-projectsgh-10062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitrilc dmitrilc

Labels
in: docs An issue in Documentation or samples status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes references to AuthenticationFailureEvent, which does not exist dmitrilc/spring-security
3 participants
@jzheaux @dmitrilc @spring-projects-issues