Skip to content

Add RestOperations implementation of OAuth2AccessTokenResponseClient #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Jul 20, 2018 · 0 comments
Closed

Add RestOperations implementation of OAuth2AccessTokenResponseClient #5547

jgrandja opened this issue Jul 20, 2018 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.1.0.RC2

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Jul 20, 2018 •
edited
Loading

The current (and default) implementation of OAuth2AccessTokenResponseClient for the authorization_code grant is NimbusAuthorizationCodeTokenResponseClient, which leverages the Nimbus HTTP Client internally.

We should provide a new implementation of OAuth2AccessTokenResponseClient for the authorization_code grant named DefaultAuthorizationCodeTokenResponseClient that uses RestOperations for requesting to the Token Endpoint.

Additionally, DefaultAuthorizationCodeTokenResponseClient should expose setRestOperations(restOperations) method to allow user's the ability to supply a pre-configured RestOperations, which can provide the user the capability to add custom parameters and/or headers if required.

DefaultAuthorizationCodeTokenResponseClient should be the new default in OAuth2LoginConfigurer and OAuth2ClientConfigurer.

Related #5601
@jgrandja jgrandja added New Feature in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jul 20, 2018
@jgrandja jgrandja added this to the 5.1.0.RC1 milestone Jul 20, 2018
@jgrandja jgrandja changed the title Add WebClient implementation of OAuth2AccessTokenResponseClient Add RestOperations implementation of OAuth2AccessTokenResponseClient Jul 20, 2018
This was referenced Jul 24, 2018
Closed
Closed
@jgrandja jgrandja self-assigned this Jul 30, 2018
@jgrandja jgrandja mentioned this issue Aug 10, 2018
Closed
@jgrandja jgrandja modified the milestones: General Backlog, 5.1.0.RC2 Aug 21, 2018
jgrandja added a commit to jgrandja/spring-security that referenced this issue Aug 25, 2018
@jgrandja
Add DefaultAuthorizationCodeTokenResponseClient
34f7f5d 
Fixes spring-projectsgh-5547
@jgrandja jgrandja mentioned this issue Oct 3, 2018
Closed
@rwinch rwinch added the type: enhancement A general enhancement label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.0.RC2
Development

Successfully merging a pull request may close this issue.

Add support for customizing the Access Token Request jgrandja/spring-security
2 participants
@rwinch @jgrandja