Skip to content

Fix Typo in Reference Docs #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dongmyo opened this issue Nov 13, 2018 · 1 comment
Closed

Fix Typo in Reference Docs #6076

dongmyo opened this issue Nov 13, 2018 · 1 comment
Assignees
@rwinch
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone
5.2.0.M1

Comments

@dongmyo
Copy link
Contributor

dongmyo commented Nov 13, 2018

Summary

a typo error in spring security reference
not JacksonJacksonModules but SecurityJacksonModules

https://github.com/spring-projects/spring-security/blob/master/docs/manual/src/docs/asciidoc/_includes/servlet/architecture/jackson.adoc

Actual Behavior

To use it, register the JacksonJacksonModules.getModules(ClassLoader) ...

Expected Behavior

To use it, register the SecurityJacksonModules.getModules(ClassLoader) ...

Version

5.1.1.RELEASE
@jzheaux
Copy link
Contributor

jzheaux commented Nov 13, 2018

@dongmyo, thanks for the report! Would you like to submit a PR with the correction?

dongmyo added a commit to dongmyo/spring-security-1 that referenced this issue Nov 14, 2018
@dongmyo
Fix Typo in Reference Docs
05e7148 
Fixes spring-projectsgh-6076
@dongmyo dongmyo mentioned this issue Nov 14, 2018
Merged
@rwinch rwinch closed this as completed in b2c2f84 Nov 14, 2018
rwinch pushed a commit that referenced this issue Nov 14, 2018
@dongmyo @rwinch
Fix Typo in Reference Docs
dc5f5f3 
Fixes gh-6076
@rwinch rwinch added this to the 5.2.0.M1 milestone Nov 14, 2018
@rwinch rwinch self-assigned this Nov 14, 2018
@rwinch rwinch mentioned this issue Nov 14, 2018
Closed
@rwinch rwinch changed the title fix typo in reference docs: not JacksonJacksonModules but SecurityJacksonModules Fix Typo in Reference Docs Nov 14, 2018
@rwinch rwinch added in: docs An issue in Documentation or samples type: bug A general bug labels Nov 14, 2018
jer051 pushed a commit to jer051/spring-security that referenced this issue Nov 21, 2018
@dongmyo
Fix Typo in Reference Docs
5bc0fdc 
Fixes spring-projectsgh-6076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Milestone
5.2.0.M1
Development

No branches or pull requests
3 participants
@dongmyo @rwinch @jzheaux