Skip to content

MethodSecurityEvaluationContext Should Check Parameter Names Are Not Null #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwinch opened this issue Dec 4, 2018 · 10 comments
Closed
Labels
in: core An issue in spring-security-core status: first-timers-only An issue that can only be worked on by brand new contributors type: bug A general bug
Milestone

Comments

@rwinch
Copy link
Member

rwinch commented Dec 4, 2018

Summary

Spring Security's MethodSecurityEvaluationContext should ignore parameter names that are null.

Related: https://jira.spring.io/browse/SPR-17565

@rwinch rwinch added in: core An issue in spring-security-core type: bug A general bug status: ideal-for-contribution An issue that we actively are looking for someone to help us with status: first-timers-only An issue that can only be worked on by brand new contributors labels Dec 4, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 4, 2018
@shraiysh
Copy link
Contributor

shraiysh commented Dec 5, 2018

Hi @rwinch, I would like to take this one.

@rwinch
Copy link
Member Author

rwinch commented Dec 5, 2018

Thanks for the offer. I'd like to keep this for a first time contributor for the moment. If you are looking for more issues, please check out the help wanted and exclude the first timers only label. Here is the query if you need it https://github.com/spring-projects/spring-security/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22help+wanted%22+sort%3Aupdated-desc++-label%3Afirst-timers-only

@shabari004
Copy link

Hi can i work on this

@rwinch
Copy link
Member Author

rwinch commented Dec 5, 2018

Thank you for volunteering to work on this @shabari004! The issue is yours. Please let me know if you need any help.

@shabari004
Copy link

@rwinch i dont see any test cases for this class, do we need any test cases for this

@shraiysh
Copy link
Contributor

shraiysh commented Dec 6, 2018

Thanks @rwinch.

@rwinch
Copy link
Member Author

rwinch commented Dec 6, 2018

@rwinch i dont see any test cases for this class, do we need any test cases for this

@shabari004 There are not currently unit tests as this is tested in other places. However, I think it would make sense for this scenario to create unit tests.

@shabari004
Copy link

@rwinch sorry to bother you, can i get some help in creating the test cases please.

@rwinch
Copy link
Member Author

rwinch commented Dec 7, 2018

@shabari004 You may. What help do you need? Can you describe the problem you are having? Can you post a branch with the code you have?

@shabari004
Copy link

@rwinch Hi i created a pull request with my code. Thanks

shabari004 added a commit to shabari004/spring-security that referenced this issue Dec 19, 2018
shabari004 added a commit to shabari004/spring-security that referenced this issue Dec 19, 2018
shabari004 added a commit to shabari004/spring-security that referenced this issue Dec 20, 2018
…not null before calling setVariable

Fixes: 17565

adding Junit test MethodSecurityEvaluationContext setVariable
Fixes: spring-projectsgh-6223

Update MethodSecurityEvaluationContextTests.java

changing the code to be consistent with the existing code base.
ankurpathak added a commit to ankurpathak/spring-security that referenced this issue Jan 10, 2019
rwinch pushed a commit that referenced this issue Jan 10, 2019
rwinch pushed a commit that referenced this issue Jan 10, 2019
rwinch pushed a commit that referenced this issue Jan 10, 2019
rwinch pushed a commit that referenced this issue Jan 10, 2019
@rwinch rwinch removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jan 29, 2019
@rwinch rwinch removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: first-timers-only An issue that can only be worked on by brand new contributors type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants