-
Notifications
You must be signed in to change notification settings - Fork 6k
MethodSecurityEvaluationContext Should Check Parameter Names Are Not Null #6223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @rwinch, I would like to take this one. |
Thanks for the offer. I'd like to keep this for a first time contributor for the moment. If you are looking for more issues, please check out the help wanted and exclude the first timers only label. Here is the query if you need it https://github.com/spring-projects/spring-security/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22help+wanted%22+sort%3Aupdated-desc++-label%3Afirst-timers-only |
Hi can i work on this |
Thank you for volunteering to work on this @shabari004! The issue is yours. Please let me know if you need any help. |
@rwinch i dont see any test cases for this class, do we need any test cases for this |
Thanks @rwinch. |
@shabari004 There are not currently unit tests as this is tested in other places. However, I think it would make sense for this scenario to create unit tests. |
@rwinch sorry to bother you, can i get some help in creating the test cases please. |
@shabari004 You may. What help do you need? Can you describe the problem you are having? Can you post a branch with the code you have? |
@rwinch Hi i created a pull request with my code. Thanks |
…not null before calling setVariable Fixes: 17565 adding Junit test MethodSecurityEvaluationContext setVariable Fixes: spring-projectsgh-6223 Update MethodSecurityEvaluationContextTests.java changing the code to be consistent with the existing code base.
Summary
Spring Security's MethodSecurityEvaluationContext should ignore parameter names that are
null
.Related: https://jira.spring.io/browse/SPR-17565
The text was updated successfully, but these errors were encountered: