Skip to content

Verify Samples in Build #9846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Jun 2, 2021 · 1 comment · Fixed by #10031
Closed

Verify Samples in Build #9846

jzheaux opened this issue Jun 2, 2021 · 1 comment · Fixed by #10031
Assignees
@marcusdacoregio
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone
5.6.0-M2

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jun 2, 2021

To ensure that the sample projects stay up to date, they should be included as part of the Spring Security build.
@jzheaux jzheaux added in: build An issue in the build type: enhancement A general enhancement labels Jun 2, 2021
@jzheaux jzheaux mentioned this issue Jun 2, 2021
Closed
6 tasks
@marcusdacoregio marcusdacoregio self-assigned this Jun 2, 2021
@marcusdacoregio marcusdacoregio added this to the 5.6.0-M1 milestone Jun 28, 2021
@marcusdacoregio marcusdacoregio mentioned this issue Jun 29, 2021
Merged
@marcusdacoregio
Copy link
Contributor

We should use #10019 to decide which Spring Security Samples' branch to checkout

@marcusdacoregio marcusdacoregio mentioned this issue Jul 2, 2021
Merged
@eleftherias eleftherias modified the milestones: 5.6.0-M1, 5.6.0-M2 Jul 19, 2021
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jul 27, 2021
@marcusdacoregio
Add checkSamples task
936ada4 
Closes spring-projectsgh-9846
marcusdacoregio added a commit that referenced this issue Jul 27, 2021
@marcusdacoregio
Add checkSamples task
c562d56 
Closes gh-9846
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Jul 30, 2021
@marcusdacoregio
Fix Gradle Plugin
87687bf 
Fix IncludeCheckRemotePlugin to add the default tasks even without defining the extension properties

Issue spring-projectsgh-9846
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Aug 17, 2021
@marcusdacoregio
Update Check Samples job to run in parallel
be91a78 
Issue spring-projectsgh-9846
@marcusdacoregio marcusdacoregio mentioned this issue Aug 17, 2021
Closed
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Add checkSamples task
0835014 
Closes spring-projectsgh-9846
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Fix Gradle Plugin
4319870 
Fix IncludeCheckRemotePlugin to add the default tasks even without defining the extension properties

Issue spring-projectsgh-9846
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@marcusdacoregio
Update Check Samples job to run in parallel
fe86303 
Issue spring-projectsgh-9846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M2
Development

Successfully merging a pull request may close this issue.

Verify Samples in Build marcusdacoregio/spring-security
3 participants
@jzheaux @eleftherias @marcusdacoregio