-
Notifications
You must be signed in to change notification settings - Fork 6k
Add OpenSamlAssertingPartyDetails #10794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@OrangeDog, does this meet the use case you identified in this comment:
|
I assume it does. You guys tested it, right? It will still need verification of the Let me go put some of my code examples on my top-level issue and you can hopefully put together an equivalent example for Spring 5/6. |
In this situation, I think an application can use OpenSAML to verify the signature themselves, for example: InputStream unverified = // ... retrieve metadata over HTTP
InputStream verified = // ... verify signature using OpenSAML
List<RelyingPartyRegistrations.Builder> registrations =
RelyingPartyRegistrations.collectionFromMetadata(verified); I'm not really inclined to further simplify pulling metadata over a non-TLS endpoint. That said, I appreciate the insight -- to discuss the merits of Spring Security doing signature verification further, I'd recommend opening a separate ticket to keep this PR focused on #10781. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @jzheaux. I've left some feedback inline.
...rity/saml2/provider/service/registration/OpenSamlMetadataAssertingPartyDetailsConverter.java
Outdated
Show resolved
Hide resolved
* {@link org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration.AssertingPartyDetails} | ||
* @param entity the {@link EntityDescriptor} to use | ||
* @return the | ||
* {@link org.springframework.security.saml2.provider.service.registration.OpenSamlAssertingPartyDetails.Builder} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* {@link org.springframework.security.saml2.provider.service.registration.OpenSamlAssertingPartyDetails.Builder} | |
* {@link org.springframework.security.saml2.provider.service.registration.OpenSamlMetadataAssertingPartyDetailsConverter.AssertingPartyDetails.Builder} |
/** | ||
* Build an | ||
* {@link org.springframework.security.saml2.provider.service.registration.OpenSamlAssertingPartyDetails} | ||
* @return | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* Build an | |
* {@link org.springframework.security.saml2.provider.service.registration.OpenSamlAssertingPartyDetails} | |
* @return | |
*/ | |
/** | |
* Build an | |
* {@link org.springframework.security.saml2.provider.service.registration.OpenSamlMetadataAssertingPartyDetailsConverter.AssertingPartyDetails} | |
* @return the {@link org.springframework.security.saml2.provider.service.registration.OpenSamlMetadataAssertingPartyDetailsConverter.AssertingPartyDetails} | |
*/ |
Closes gh-10781