Add X-Xss-Protection headerValue to XML config #11936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kehrlann
force-pushed
the
x-xss-protection-xml-config
branch
from
0370978 to
c756756
Compare
spring-projects-issues
added
the
status: waiting-for-triage
Kehrlann
force-pushed
the
x-xss-protection-xml-config
branch
from
c756756 to
b1a4186
Compare
sjohnr
requested changes
Oct 3, 2022
| @@ -1298,6 +1298,9 @@ xss-protection.attlist &= | |||
| xss-protection.attlist &= | |||
| ## Add mode=block to the header or not, default is on. | |||
| attribute block {xsd:boolean}? | |||
| xss-protection.attlist &= | |||
| ## Specify the value for the X-Xss-Protection header. When set, overrides both enabled and block attributes. | |||
| attribute header-value {"0","1","1\;mode=block"}? | |||
There was a problem hiding this comment.
My IDE (IntelliJ) complains about this line, with
group of "string" or "data" element
Is this the correct change to make?
There was a problem hiding this comment.
Good catch, thanks!
Changed to "0" | "1" | "1; mode=block", it generates a very similar XSD but IntelliJ doesn't complain.
Note, I am no RELAX NG expert. I "made it work" but I don't really understand how...
Kehrlann
force-pushed
the
x-xss-protection-xml-config
branch
from
b1a4186 to
8ca88d1
Compare
sjohnr
added
in: web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gh-11908