Skip to content

Jackson deserialization of ClientAuthenticationMethods should recognize all values #16826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2025
Merged

Jackson deserialization of ClientAuthenticationMethods should recognize all values #16826

merged 4 commits into from
Apr 9, 2025

Conversation

mapsu
Copy link
Contributor

@mapsu mapsu commented Mar 26, 2025

Closes gh-16825

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 26, 2025
@mapsu mapsu force-pushed the gh-16825 branch 2 times, most recently from 0bb8a89 to 42fc2e7 Compare March 26, 2025 11:01
@mapsu mapsu changed the base branch from 6.4.x to main March 28, 2025 12:03
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 31, 2025
@jzheaux jzheaux assigned jzheaux and unassigned sjohnr Mar 31, 2025
@jzheaux jzheaux changed the title Add missing ClientAuthenticationMethods to jackson2 converter Jackson serialization for ClientAuthenticationMethods should recognize all ClientAuthenticationMethods Mar 31, 2025
@jzheaux jzheaux changed the title Jackson serialization for ClientAuthenticationMethods should recognize all ClientAuthenticationMethods Jackson serialization for ClientAuthenticationMethods should recognize all values Mar 31, 2025
jzheaux
jzheaux requested changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mapsu, for the PR! I've left feedback inline.

@jzheaux jzheaux changed the title Jackson serialization for ClientAuthenticationMethods should recognize all values Jackson deserialization of ClientAuthenticationMethods should recognize all values Apr 2, 2025
@mapsu
Formatted
28c8bd2 
Signed-off-by: Risto Virtanen <[email protected]>
@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Apr 9, 2025
@jzheaux jzheaux merged commit 47e1fc0 into spring-projects:main Apr 9, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Apr 9, 2025

Thanks for the PR, @mapsu! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
Spring Security Team
Status: No status
Milestone
6.5.0-RC1
Development

Successfully merging this pull request may close these issues.

Not all OAuth2 ClientAuthenticationMethods are supported in Jackson2 converters
4 participants
@mapsu @jzheaux @sjohnr @spring-projects-issues