Skip to content

Add JdbcAssertingPartyMetadataRepository #17077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add JdbcAssertingPartyMetadataRepository #17077

wants to merge 4 commits into from

Conversation

wapkch
Copy link

@wapkch wapkch commented May 8, 2025

Closes gh-16012

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 8, 2025
@jzheaux jzheaux self-assigned this May 20, 2025
@jzheaux jzheaux removed the status: waiting-for-triage An issue we've not yet triaged label May 20, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 20, 2025
jzheaux
jzheaux requested changes May 23, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @wapkch, thanks for this PR! Looking at #16012, I believe the ask is to be able to have separate places from which to draw information for the RP and AP metadata. As such, I think let's begin with implementing AssertingPartyMetadataRepository (so JdbcAssertingPartyMetadataRepository). You should be able to preserve most of what you've written, just staying focused on the asserting party. Are you able to make these changes?

@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels May 23, 2025
@wapkch
Copy link
Author

wapkch commented May 30, 2025

Hi, @wapkch, thanks for this PR! Looking at #16012, I believe the ask is to be able to have separate places from which to draw information for the RP and AP metadata. As such, I think let's begin with implementing AssertingPartyMetadataRepository (so JdbcAssertingPartyMetadataRepository). You should be able to preserve most of what you've written, just staying focused on the asserting party. Are you able to make these changes?

Thanks for the feedback! Yes, I can make those changes. Appreciate the guidance!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 30, 2025
@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jun 2, 2025
@jzheaux jzheaux changed the title Add JdbcRelyingPartyRegistrationRepository Add JdbcAssertingPartyMetadaaRepository Jun 5, 2025
@jzheaux jzheaux changed the title Add JdbcAssertingPartyMetadaaRepository Add JdbcAssertingPartyMetadataRepository Jun 5, 2025
chao.wang and others added 4 commits June 5, 2025 15:33
@jzheaux
Add JdbcAssertingPartyMetadataRepository
118b9ec 
Closes spring-projectsgh-16012

Signed-off-by: chao.wang <[email protected]>
@jzheaux
Fix Checkstyle
bb1473e 
Issue spring-projectsgh-16012
@jzheaux
Add JdbcAssertingPartyMetadataRepository#save
42708d2 
Issue spring-projectsgh-16012

Co-Authored-By: chao.wang <[email protected]>
@jzheaux
Polish JdbcAssertingPartyMetadataRepository
8ef027a 
- Remove GetBytes since it's not used yet
- Remove customizable RowMapper since this can be added
later
- Change signing_algorithms to be a String since the conversion
strategy is simple
- Standardize test names
- Simplify conversion of credentials using ThrowingFunction

Issue spring-projectsgh-16012
@jzheaux
Copy link
Contributor

jzheaux commented Jun 5, 2025

This is looking good, @wapkch. I added some polishes in 86189f3. Also, I polished your original save method and placed that in a separate commit that marks you as co-author so that you get credit for that initial work. Let me know if that works for you. If so, I think that this is ready to merge; thanks for your help!

@jzheaux jzheaux removed the status: waiting-for-feedback We need additional information before we can continue label Jun 5, 2025
@jzheaux jzheaux added this to the 7.0.0-M1 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.0-M1
Development

Successfully merging this pull request may close these issues.

Add JdbcRelyingPartyRegistrationRepository
3 participants
@wapkch @jzheaux @spring-projects-issues