Throw PasswordPolicyException not only when account is locked #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when account is locked only.
|
I'm afraid that translating a non-null ErrorStatus to PasswordPolicyException is not specific enough. If there is something more specific that you had in mind, please feel free to open a new pull request using the Contributor Guidelines as a guideline on how to proceed. Also keep in mind that there are quite a number of different OpenID implementations that will also be impacted. |
This was referenced Feb 5, 2016
bclozel
added a commit
to bclozel/spring-security
that referenced
this pull request
Jan 4, 2017
Conditionalize reference doc/api doc links
rwinch
added a commit
that referenced
this pull request
Apr 21, 2025
rwinch
added a commit
that referenced
this pull request
Apr 21, 2025
- Update to io.spring.gradle:spring-security-release-plugin:1.0.5 Closes gh-6.3.10 in 6.4.x
rwinch
added a commit
that referenced
this pull request
Apr 21, 2025
- io.spring.gradle:spring-security-release-plugin:1.0.5 Closes gh-6.3.10 in 6.4.x in 6.5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the original code spring-security-ldap throws PasswordPolicyException only when an account is locked. With this small change (tested against openldap), PasswordPolicyException are to be thrown when ErrorStatus is not null which covers most, if not all, ppolicy cases...