Skip to content

Reinstantiate support for Apache Axiom now that is supports jakarta #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gigermocas opened this issue Feb 18, 2025 · 5 comments
Closed

Reinstantiate support for Apache Axiom now that is supports jakarta #1454

gigermocas opened this issue Feb 18, 2025 · 5 comments
Assignees
@snicoll
Labels
type: enhancement A general enhancement
Milestone
4.1.0-M1

Comments

@gigermocas
Copy link

Can support for Apache Axiom be reintroduced?

Support was dropped for v4 due to it still targeting Java EE 8, but the latest Axiom release seems to have fixed this:
https://ws.apache.org/axiom/release-notes/2.0.0.html
@snicoll snicoll added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2025
@mdeinum
Copy link
Contributor

mdeinum commented Mar 5, 2025

Related (Duplicate?): #1257

@snicoll snicoll changed the title Support for Apache Axiom Reinstantiate support for Apache Axiom now that is supports jakarta Mar 5, 2025
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 5, 2025
@snicoll snicoll added this to the 4.1.x milestone Mar 5, 2025
@snicoll
Copy link
Member

snicoll commented Mar 5, 2025

I don't know yet as I am still discovering things. I've triaged this one for the next feature release and we can see accordingly.

@snicoll snicoll marked this as a duplicate of #1257 Mar 7, 2025
@snicoll snicoll self-assigned this Mar 13, 2025
@snicoll
Copy link
Member

snicoll commented Mar 13, 2025

I am hacking on https://github.com/snicoll/spring-ws/tree/gh-1454

I believe I've made good progress but some code has been flagged legacy so I need to review that stuff.

@snicoll
Copy link
Member

snicoll commented Mar 13, 2025 •
edited
Loading

Attachments should use MultipartBody.

@snicoll
Copy link
Member

snicoll commented Mar 14, 2025

Unfortunately that doesn't work. MultipartBody is an immutable class and we can't use it to implement jakarta.xml.soap.SOAPMessage. Axis doesn't even use it at all.

snicoll added a commit that referenced this issue Mar 14, 2025
@snicoll
Reinstantiate support for Apache Axiom
60942af 
This commit restores support for Apache Axiom now that it supports
Jakarta. This commit tries to restore the code that was deleted as-is,
without reviewing the deprecations.

See gh-1454
snicoll added a commit that referenced this issue Mar 14, 2025
@snicoll
Adapt deprecated code in Axiom 2
2c1abc6 
This commit removes the compat module and adapt the deprecated code.

See gh-1454
@snicoll snicoll modified the milestones: 4.1.x, 4.1.0-M1 Mar 14, 2025
snicoll added a commit that referenced this issue Mar 25, 2025
@snicoll
Polish
c1079e7 
See gh-1454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.1.0-M1
Development

No branches or pull requests
3 participants
@snicoll @mdeinum @gigermocas