Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable release 2.7.0 depends on Spring Cloud Milestone 4.2.0-M1 #2804

Closed
aheritier opened this issue Dec 6, 2024 · 5 comments · Fixed by #2805
Closed

Stable release 2.7.0 depends on Spring Cloud Milestone 4.2.0-M1 #2804

aheritier opened this issue Dec 6, 2024 · 5 comments · Fixed by #2805
Labels
enhancement New feature or request

Comments

@aheritier
Copy link
Contributor

Describe the bug

As seen in the pom The release depends on a milestone. It's requiring a specific repository (and companies might block such kind of non final release artifacts)

To Reproduce

mvn dependency:list returns spring-cloud-function-web 4.2.0-M1

Expected behavior

mvn dependency:list should return spring-cloud-function-web 4.2.0
@aheritier aheritier mentioned this issue Dec 6, 2024
Merged
@bnasslahsen
Copy link
Collaborator

bnasslahsen commented Dec 7, 2024 •
edited
Loading

@aheritier,

The current version of spring-cloud-function has been compiled with more recent version of kotlin: 2.1.0
image

That's why it hasn't been integrated in the first place. We could not wait for this issue to be fixed...

I am adding a reproducer project the spring-cloud-function project. Maybe we will get a fix for it soon.
spring-cloud/spring-cloud-function#1218

@bnasslahsen bnasslahsen reopened this Dec 7, 2024
@bnasslahsen bnasslahsen added the enhancement New feature or request label Dec 7, 2024
@aheritier
Copy link
Contributor Author

Thanks @bnasslahsen i missed that sorry 😢

@olegz
Copy link

olegz commented Dec 10, 2024

It's been addressed with spring-cloud/spring-cloud-function@0a43fc9
Apparently we need to be explicit about it as it can randomly pick 2.1. . .

bnasslahsen added a commit that referenced this issue Dec 10, 2024
@bnasslahsen
Testing with 4.2.1-SNAPSHOT, for spring-cloud-function. #2804
19653f9
@bnasslahsen
Copy link
Collaborator

@olegz,

Thanks a lot @olegz for your quick response.
I confirm, it's working fine with 4.2.1-SNAPSHOT

Looking forward to 4.2.1 👍

@bnasslahsen bnasslahsen mentioned this issue Dec 28, 2024
Closed
bnasslahsen added a commit that referenced this issue Jan 3, 2025
@bnasslahsen
Adding workaround for #2804
edbf166
@bnasslahsen
Copy link
Collaborator

Released in 2.8.0 with a workaround for spring-cloud-function 4.2.0 compilation!

ndwlocatieservices added a commit to ndwnu/nls-accessibility-map that referenced this issue Jan 14, 2025
@ndwlocatieservices
Merged PR 71991: Update all non-major dependencies
6820889 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [nu.ndw.nls.locationdataissuesapi:client-feign](https://dev.azure.com/ndwnu/NLS/_git/nls-location-data-issues) ([source](https://dev.azure.com/ndwnu/NLS/_git/nls-location-data-issues)) | compile | patch | `1.0.17` -> `1.0.18` |
| [org.springdoc:springdoc-openapi-starter-webmvc-ui](https://springdoc.org/) ([source](https://github.com/springdoc/springdoc-openapi)) | compile | minor | `2.7.0` -> `2.8.0` |

---

### Release Notes

<details>
<summary>springdoc/springdoc-openapi (org.springdoc:springdoc-openapi-starter-webmvc-ui)</summary>

### [`v2.8.0`](https://github.com/springdoc/springdoc-openapi/blob/HEAD/CHANGELOG.md#280---2025-01-03)

[Compare Source](springdoc/springdoc-openapi@v2.7.0...v2.8.0)

##### Added

-   [#&#8203;2790](springdoc/springdoc-openapi#2790) - Moving to OpenAPI 3.1 as the default implementation for springdoc-openapi
-   [#&#8203;2817](springdoc/springdoc-openapi#2817) - Obey annotations when flattening ParameterObject fields
-   [#&#8203;2826](springdoc/springdoc-openapi#2826) - Make it possible to mark parameters with [@&#8203;RequestParam](https://github.com/RequestParam) annotation to be sent in form instead of query.
-   [#&#8203;2822](springdoc/springdoc-openapi#2822) - Support returning null in ParameterCustomizer
-   [#&#8203;2830](springdoc/springdoc-openapi#2830) - Add support for deprecated fields.
-   [#&#8203;2780](springdoc/springdoc-openapi#2780) - Add Security Schema by AutoConfigure

##### Changed

-   Upgrade spring-boot to 3.4.1
-   Upgrade spring-cloud-function to 4.2.0
-   Upgrade swagger-core to 2.2.27

##### Fixed

-   [#&#8203;2804](springdoc/springdoc-openapi#2804) - Stable release 2.7.0 depends on Spring Cloud Milestone 4.2.0-M1
-   [#&#8203;2828](springdoc/springdoc-openapi#2828) - Required a bean of type 'org.springframework.data.rest.webmvc.mapping.Associations' that could not be found.
-   [#&#8203;2823](springdoc/springdoc-openapi#2823) - Capturing pattern in identical paths only renders the path element of one method
-   [#&#8203;2817](springdoc/springdoc-openapi#2817) - Automatically add required if a field is [@&#8203;notNull](https://github.com/notNull) or [@&#8203;NotBlank](https://github.com/NotBlank).
-   [#&#8203;2814](springdoc/springdoc-openapi#2814) - An unresolvable circular reference with management.endpoint.gateway.enabled=true.
-   [#&#8203;2798](springdoc/springdoc-openapi#2798) - Object schema generated for Unit Kotlin type.
-   [#&#8203;2797](springdoc/springdoc-openapi#2797) - Removing operationId via customizer does not w...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade spring-cloud-function from 4.2.0-M1 to 4.2.0 aheritier/springdoc-openapi
3 participants
@olegz @aheritier @bnasslahsen