Ensure default media type order is preserved using LinkedHashSet in mergeArrays. Fixes #2671 #2672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2671 - Ensure default media type order is preserved using LinkedHashSet in mergeArrays
Description
This PR addresses issue #2671 by ensuring that the order of media types is preserved in the
mergeArrays
method of theMethodAttributes
class. Previously,HashSet
was used, which did not guarantee the order of media types, causing the default media type not to be prioritized. This has been fixed by usingLinkedHashSet
to maintain the insertion order.Changes
MethodAttributes.java:
mergeArrays
method to useLinkedHashSet
instead ofHashSet
to preserve the order of media types.MethodAttributesTest.java:
mergeArrays
method preserves the order of media types and that the default media type is prioritized.Testing
Added the following tests to
MethodAttributesTest
to ensure the functionality:testMergeArrays
: Verifies that the order of media types is preserved when merging two arrays.testMergeArraysWithNullArray1
: Verifies that the method handlesnull
as the first array correctly.testDefaultProducesMediaType
: Verifies that the defaultproduces
media type is correctly set.testDefaultConsumesMediaType
: Verifies that the defaultconsumes
media type is correctly set.Please review the changes and let me know if any further adjustments are needed.
Thank you!