Add OpenApiBuilderCustomiser #451
Merged
+274
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnasslahsen
requested changes
Feb 24, 2020
There was a problem hiding this comment.
Hi @ptahchiev,
Can you please add unit tests for your changes, so we can test the usage of OpenApiBuilderCustomiser ?
Thank you for your contribution.
|
Hi @bnasslahsen - I've added a test-case. |
|
@bnasslahsen Is there anything else I need to improve on the PR? The longer it waits the more conflicts appear - i see now you added 92 test and now I have conflicts with my branch :( |
|
Hi @ptahchiev, Your PR is merged with master and will be available on the next release: 1.2.33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OpenApiBuilderCustomiser to allow users to customize the OpenApiBuilder.
In our case we have our own custom annotation
FacadeRestResource(much similar to spring-data-restRepositoryRestResource) and we need a way to allow the OpenApiBuilder to scan beans for our annotation.With the proposed change we introduce a new interface called
OpenApiBuilderCustomiserand thus we can create our own customizer to provide the additional Map of mappings.