fix(postgresql): add options to create statements #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
jamesarosen
commented
Mar 25, 2025
| 'CREATE SEQUENCE', | ||
| 'CREATE [OR REPLACE] RULE', | ||
| 'CREATE SCHEMA [AUTHORIZATION]', | ||
| 'CREATE {TEMPORARY | TEMP | UNLOGGED} SEQUENCE', |
There was a problem hiding this comment.
I think this is the right syntax. Please compare with https://www.postgresql.org/docs/17/sql-createsequence.html
There was a problem hiding this comment.
Not quite. The [ { TEMPORARY | TEMP } | UNLOGGED ] in postgres docs is really equivalent to just: [ TEMPORARY | TEMP | UNLOGGED ].
Many of the `CREATE ...` statements in the postgres dialect were missing options, especially the `OR REPLACE` option that is common to many commands. Fixes #850
jamesarosen
force-pushed
the
fix-pg-create-options
branch
from
5b9a36d to
cd8cfd7
Compare
nene
added a commit
that referenced
this pull request
Mar 26, 2025
|
Thanks for putting in effort to fix more things than just your immediate problem 👍 |
|
Released in 15.5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the
CREATE ...statements in the postgres dialect were missing options, especially theOR REPLACEoption that is common to many commands.Fixes #850