Skip to content

modify readMe bug #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Conversation

Kelang-Tian
Copy link
Collaborator

First pull request test.

docker build -t sqlflow:dev . -> docker build -t sqlflow:dev -f docker/dev/Dockerfile .
https://github.com/sql-machine-learning/sqlflow/blob/develop/docker/dev/README.md

The documentation is imperfect.
You need to tell the user to execute the command in the root directory and specify the location of the dockerfile.

Copy link
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks to polishing this tutorial, I left a tiny comment, please update as it and then we can merge this PR.

@@ -7,10 +7,10 @@ code of SQLFlow.

## Build the DevBox Image

In this directory, run the following command.
In the root directory of this project, run the following command.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trim the last space character.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kelang-Tian Kelang-Tian merged commit 73135b2 into sql-machine-learning:develop Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants