Skip to content

fix Insert.on_conflict_do_nothing return type #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2022
Merged

fix Insert.on_conflict_do_nothing return type #246

merged 1 commit into from
Dec 22, 2022

Conversation

izeberg
Copy link
Contributor

@izeberg izeberg commented Dec 22, 2022

Bump issue #212

Fix typing for dialects.postgresql.dml.Insert.on_conflict_do_nothing.

CaselIT
CaselIT approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@CaselIT CaselIT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that was indeed a bug.

will release shortly

@CaselIT CaselIT merged commit b7e285f into sqlalchemy:main Dec 22, 2022
@izeberg izeberg deleted the patch-1 branch December 22, 2022 19:24
@CaselIT
Copy link
Member

CaselIT commented Dec 22, 2022

released as https://github.com/sqlalchemy/sqlalchemy2-stubs/releases/tag/v0.0.2a31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaselIT CaselIT CaselIT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izeberg @CaselIT