Skip to content

Pass props to WorkflowActions #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zach-klippenstein opened this issue Jan 27, 2020 · 0 comments · Fixed by #81
Closed

Pass props to WorkflowActions #56

zach-klippenstein opened this issue Jan 27, 2020 · 0 comments · Fixed by #81
Assignees
Milestone

Comments

@zach-klippenstein
Copy link
Collaborator

It's come up a couple of times, at least in Kotlin, that WorkflowActions get the state of the current workflow but not its props. Since we consider props to be part of the workflow's overall "state", it seems unintuitive that we only pass part of that to actions.

The reason for not doing this was, initially, to discourage side effects from being performed in actions. However, we realized that is too restrictive (see this Slack discussion).

Note for Swift this means passing the Workflow value itself into the action, since there's no separate props type.

Kotlin version of square/workflow-swift#139.

@zach-klippenstein zach-klippenstein transferred this issue from square/workflow Jun 27, 2020
@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Jun 27, 2020
@zach-klippenstein zach-klippenstein changed the title [kotlin] Pass props to WorkflowActions Pass props to WorkflowActions Jun 28, 2020
zach-klippenstein added a commit that referenced this issue Jun 28, 2020
@rjrjr rjrjr self-assigned this Jun 29, 2020
rjrjr added a commit that referenced this issue Jun 29, 2020
rjrjr added a commit that referenced this issue Jun 29, 2020
rjrjr added a commit that referenced this issue Jun 29, 2020
rjrjr added a commit that referenced this issue Jun 29, 2020
rjrjr added a commit that referenced this issue Jun 29, 2020
@rjrjr rjrjr closed this as completed in #81 Jun 29, 2020
zach-klippenstein added a commit that referenced this issue Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants