-
Notifications
You must be signed in to change notification settings - Fork 101
Pass props to WorkflowActions #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
zach-klippenstein
added a commit
that referenced
this issue
Jun 28, 2020
rjrjr
added a commit
that referenced
this issue
Jun 29, 2020
rjrjr
added a commit
that referenced
this issue
Jun 29, 2020
rjrjr
added a commit
that referenced
this issue
Jun 29, 2020
rjrjr
added a commit
that referenced
this issue
Jun 29, 2020
rjrjr
added a commit
that referenced
this issue
Jun 29, 2020
zach-klippenstein
added a commit
that referenced
this issue
Feb 4, 2021
Update Jetpack Compose to dev15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's come up a couple of times, at least in Kotlin, that
WorkflowAction
s get the state of the current workflow but not its props. Since we consider props to be part of the workflow's overall "state", it seems unintuitive that we only pass part of that to actions.The reason for not doing this was, initially, to discourage side effects from being performed in actions. However, we realized that is too restrictive (see this Slack discussion).
Note for Swift this means passing the
Workflow
value itself into the action, since there's no separate props type.Kotlin version of square/workflow-swift#139.
The text was updated successfully, but these errors were encountered: