Skip to content

Add a renderTester method for expecting typed workers #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zach-klippenstein opened this issue Apr 20, 2020 · 1 comment · Fixed by #110
Closed

Add a renderTester method for expecting typed workers #92

zach-klippenstein opened this issue Apr 20, 2020 · 1 comment · Fixed by #110

Comments

@zach-klippenstein
Copy link
Collaborator

Eg expectTypedWorker. It's technically a bit weird because it's basically leaking an implementation detail of a private type, but it's been asked for internally, I think it's probably a super common use case, and the fact that that behavior is a private implementation detail is weird to begin with.

I think it will also become less weird after we get implement GUWT.
@zach-klippenstein
Copy link
Collaborator Author

Additive, not 1.0 blocker.

@zach-klippenstein zach-klippenstein transferred this issue from square/workflow Jul 1, 2020
zach-klippenstein added a commit that referenced this issue Jul 1, 2020
@zach-klippenstein
WIP Reimplemented Workers using side effects.
cb0008b 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 1, 2020
@zach-klippenstein
WIP Reimplemented Workers using side effects.
e775eb2 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 1, 2020
@zach-klippenstein
WIP Reimplemented Workers using side effects.
2f68557 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 8, 2020
@zach-klippenstein
WIP Reimplemented Workers using side effects.
e328ea5 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 9, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
480469c 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
@zach-klippenstein zach-klippenstein mentioned this issue Jul 9, 2020
Merged
zach-klippenstein added a commit that referenced this issue Jul 9, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
4f6a074 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 9, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
d47b57d 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 9, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
585ba45 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 11, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
42859d0 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 11, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
6c2e14d 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 11, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
76b2c37 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
zach-klippenstein added a commit that referenced this issue Jul 11, 2020
@zach-klippenstein
Reimplemented Workers using side effects.
5a883c6 
Issues:
 - Fixes #82, which is the Kotlin half of square/workflow#1021.
 - Fixes #92.
 - Fixes square/workflow#1197.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reimplemented Workers using side effects (GUWT). square/workflow-kotlin
1 participant
@zach-klippenstein