Add CoroutineScope to initialState; SessionWorkflow to aid rollout #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love this. |
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
rjrjr
approved these changes
Sep 1, 2023
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/BaseRenderContext.kt
Outdated
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/BaseRenderContext.kt
Outdated
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/BaseRenderContext.kt
Outdated
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/LifecycleWorker.kt
Outdated
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/SessionWorkflow.kt
Outdated
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/StatefulWorkflow.kt
Show resolved
Hide resolved
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/SessionWorkflow.kt
Outdated
Show resolved
Hide resolved
workflow-testing/src/test/java/com/squareup/workflow1/ParameterizedTestRunner.kt
Show resolved
Hide resolved
Adds 'Lifecycle' related tests to prove out SessionWorkflow's ability to effectively track lifecycle in the failing scenario. Adds comments describing the failing scenario of issue 1093, and how this can workaround it to fix it. Also address 990 which has been separately requested. Closes 990 Closes 1093
steve-the-edwards
force-pushed
the
sedwards/session-workflow-scope
branch
from
2b77964 to
40e106e
Compare
steve-the-edwards
changed the base branch from
sedwards/add-headless-integration-test
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'Lifecycle' related tests to prove out SessionWorkflow's ability to effectively track lifecycle in the failing scenario. Adds comments describing the failing scenario of issue #1093, and how this can workaround it to fix it.
Also address #990 which has been separately requested.
Also adds
HeadlessIntegrationTestto the OSS Library, which we have used internally for some time.Closes #990
Closes #1093