Fixes memory leak in ViewStateCache. #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ViewStateCache` was `Parcelable`, in an attempt to simplify `View.onSaveInstanceState()` chores for client container views. That became a source of memory leaks once we added a `WorkflowSavedStateRegistryAggregator` to it, so we've dialed back the convenience. `ViewStateCache` now offers `save(): Saved` and `restore(saved: Saved)`, where `Saved` is a simple `Parcelable`. Client views are responsible for managing their own subclasses of `View.BaseSavedState`, which is sad but not terribly unusual.
rjrjr
force-pushed
the
ray/view-state-cache-leak-oops
branch
from
782d604 to
c515971
Compare
|
Before putting this PR up for review, I'm publishing it as |
steve-the-edwards
approved these changes
Apr 12, 2022
That was dumb, it got stomped immediately. Making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ViewStateCachewasParcelable, in an attempt to simplifyView.onSaveInstanceState()chores for client container views. That became a source of memory leaks once we added aWorkflowSavedStateRegistryAggregatorto it, so we've dialed back the convenience.ViewStateCachenow offerssave(): Savedandrestore(saved: Saved), whereSavedis a simpleParcelable. Client views are responsible for managing their own subclasses ofView.BaseSavedState, which is sad but not terribly unusual.