Add Baseline and Perf Tests to Perf Poetry #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/update-benchmarks-readme
branch
6 times, most recently
from
2f01386 to
ec8d5f6
Compare
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
workflow-runtime/src/main/java/com/squareup/workflow1/internal/WorkflowRunner.kt
Outdated
Show resolved
Hide resolved
workflow-runtime/src/main/java/com/squareup/workflow1/internal/WorkflowNode.kt
Outdated
Show resolved
Hide resolved
steve-the-edwards
force-pushed
the
sedwards/update-benchmarks-readme
branch
from
ec8d5f6 to
0f29743
Compare
|
Still more work to do to refine these and establish the best scenarios, but this is a good basis and gets us setup in the application 'complex-poetry' where we should focus our performance testing in. |
pyricau
reviewed
Apr 12, 2022
pyricau
reviewed
Apr 12, 2022
pyricau
reviewed
Apr 12, 2022
pyricau
reviewed
Apr 12, 2022
pyricau
reviewed
Apr 12, 2022
pyricau
reviewed
Apr 12, 2022
pyricau
reviewed
Apr 12, 2022
rjrjr
reviewed
Apr 12, 2022
workflow-runtime/src/main/java/com/squareup/workflow1/internal/WorkflowNode.kt
Outdated
Show resolved
Hide resolved
steve-the-edwards
force-pushed
the
sedwards/update-benchmarks-readme
branch
2 times, most recently
from
56d4508 to
17ed0c5
Compare
...n/java/com/squareup/benchmarks/performance/poetry/complex/benchmark/ComplexPoetryResults.txt
Outdated
Show resolved
Hide resolved
rjrjr
approved these changes
Apr 13, 2022
rjrjr
reviewed
Apr 13, 2022
...c/main/java/com/squareup/benchmarks/performance/complex/poetry/PerformancePoetryComponent.kt
Outdated
Show resolved
Hide resolved
pyricau
reviewed
Apr 13, 2022
...enchmark/src/main/java/com/squareup/sample/dungeon/benchmark/DungeonGatherBaselineProfile.kt
Show resolved
Hide resolved
pyricau
reviewed
Apr 13, 2022
benchmarks/performance-poetry/complex-benchmark/build.gradle.kts
Outdated
Show resolved
Hide resolved
pyricau
reviewed
Apr 13, 2022
| } | ||
|
|
||
| // kotlin_builtins duplication between 1.5.20 and 1.6.10? | ||
| packagingOptions.exclude("**/*.kotlin_*") |
pyricau
reviewed
Apr 13, 2022
| } | ||
|
|
||
| dependencies { | ||
| implementation(project(":benchmarks:performance-poetry:complex-poetry")) |
There was a problem hiding this comment.
so what's a complex benchmark? What's a not complex one? Are there more interesting words we can use to describe the difference?
There was a problem hiding this comment.
Unless... this is about "ComplexPoetry". Why couldn't that have been just Poetry?!
There was a problem hiding this comment.
lol. This is a 'Complex' version of the Poetry app.
pyricau
reviewed
Apr 13, 2022
| benchmarkRule.measureRepeated( | ||
| packageName = PACKAGE_NAME, | ||
| metrics = traceMetricsList, | ||
| iterations = 20, |
There was a problem hiding this comment.
not sure 20 is enough. What's the distribution looking like?
pyricau
reviewed
Apr 13, 2022
...n/java/com/squareup/benchmarks/performance/poetry/complex/benchmark/ComplexPoetryResults.txt
Outdated
Show resolved
Hide resolved
pyricau
reviewed
Apr 13, 2022
...n/java/com/squareup/benchmarks/performance/poetry/complex/benchmark/ComplexPoetryResults.txt
Outdated
Show resolved
Hide resolved
pyricau
reviewed
Apr 13, 2022
...c/main/java/com/squareup/benchmarks/performance/complex/poetry/PerformancePoetryComponent.kt
Outdated
Show resolved
Hide resolved
pyricau
reviewed
Apr 13, 2022
...c/main/java/com/squareup/benchmarks/performance/complex/poetry/PerformancePoetryComponent.kt
Outdated
Show resolved
Hide resolved
pyricau
reviewed
Apr 13, 2022
...c/main/java/com/squareup/benchmarks/performance/complex/poetry/PerformancePoetryComponent.kt
Outdated
Show resolved
Hide resolved
|
steve-the-edwards
force-pushed
the
sedwards/update-benchmarks-readme
branch
5 times, most recently
from
77bbe94 to
e6e0634
Compare
steve-the-edwards
force-pushed
the
sedwards/update-benchmarks-readme
branch
from
e6e0634 to
a6fcd2b
Compare
pyricau
reviewed
Apr 19, 2022
benchmarks/README.md
Outdated
| @@ -1,22 +1,27 @@ | |||
| # benchmarks | |||
|
|
|||
| This module contains benchmarks. Used to measure and help improve Workflow performance. These tests | |||
| should be run on physical devices. | |||
| should be run on physical devices, or the closest approximation to physical devices you can get. | |||
There was a problem hiding this comment.
For the deterministic tests, that's shouldn't be a requirement anymore, right?
pyricau
reviewed
Apr 19, 2022
| complexityDelay = 100L | ||
| ), | ||
| expectedPasses = 61, | ||
| expectedRatio = 0.11891891891891893 |
There was a problem hiding this comment.
Wondering if you'd want to store the ratio as 2 numbers instead? idk feels weird to store a truncated number.
There was a problem hiding this comment.
In fact, if you stored 2 numbers, you could then assert against each, and report whether there are less things fresh or more overall things.
pyricau
approved these changes
Apr 19, 2022
steve-the-edwards
force-pushed
the
sedwards/update-benchmarks-readme
branch
from
a6fcd2b to
abbea36
Compare
Use WorkflowInterceptor to count Render Passes and determine ratio of 'fresh' renderings.
steve-the-edwards
force-pushed
the
sedwards/update-benchmarks-readme
branch
from
abbea36 to
dac8999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
WorkflowInterceptorto trace each render pass as well as particular nodes within it.We use a "Fresh Rendering Ratio" which is the # of render passes for a node that had a different RenderState / the total # of render passes.