Skip to content

View.environmentOrNull, View.screenOrNull. #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Apr 26, 2022

I'd like to bring back the ability to peek at a View and see if/how workflow-ui created it, even though we no longer need that ability at runtime. I don't see how we can preserve our Radiography support without it, and it's also handy for espresso testing (#741).

@rjrjr rjrjr requested review from a team and zach-klippenstein as code owners April 26, 2022 19:38
I'd like to bring back the ability to peek at a View and see if/how workflow-ui created it, even though we no longer need that ability at runtime. I don't see how we can preserve our Radiography support without it, and it's also handy for espresso testing (#741).
@rjrjr rjrjr changed the title Brings back View.environment, adds View.getScreen. View.environmentOrNull, View.screenOrNull. Apr 26, 2022
@rjrjr rjrjr merged commit 73c2eee into ray/ui-update Apr 26, 2022
@rjrjr rjrjr deleted the ray/peekaboo branch April 26, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants