Skip to content

RenderTester's expect(publisher: ...) method should accept nil output #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamieQ opened this issue Aug 10, 2023 · 0 comments
Closed

RenderTester's expect(publisher: ...) method should accept nil output #235

jamieQ opened this issue Aug 10, 2023 · 0 comments

Comments

@jamieQ
Copy link
Contributor

jamieQ commented Aug 10, 2023

currently you cannot straightforwardly use RenderTester to test a Publisher that does not emit any output during a render pass
@jamieQ jamieQ mentioned this issue Aug 10, 2023
Merged
4 tasks
jamieQ added a commit that referenced this issue Aug 10, 2023
@jamieQ
[fix]: support nil output in RenderTester Publisher extension (#236)
082d9f1 
### Issue

- the `WorkflowCombine` `RenderTester` extensions didn't allow `nil` output

### Description

- add a new method to support `nil` output and match the naming convention of analogous methods
- deprecate old method
- update tests

addresses #235
@jamieQ jamieQ closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamieQ