Skip to content

Remove unused ReactiveSwift imports #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Remove unused ReactiveSwift imports #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Workflow/Sources/SubtreeManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

import Dispatch
import ReactiveSwift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extraneous dependency declaration somewhere that allowed this all to compile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused imports are not compile time errors.


extension WorkflowNode {
/// Manages the subtree of a workflow. Specifically, this type encapsulates the logic required to update and manage
Expand Down Expand Up @@ -391,8 +390,6 @@ extension WorkflowNode.SubtreeManager {
private let node: WorkflowNode<W>
private var outputMap: (W.Output) -> AnyWorkflowAction<WorkflowType>

private let (lifetime, token) = ReactiveSwift.Lifetime.make()

init(workflow: W, outputMap: @escaping (W.Output) -> AnyWorkflowAction<WorkflowType>, eventPipe: EventPipe) {
self.outputMap = outputMap
self.node = WorkflowNode<W>(workflow: workflow)
Expand Down
2 changes: 0 additions & 2 deletions Workflow/Sources/Workflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
* limitations under the License.
*/

import ReactiveSwift

/// Defines a node in the workflow tree.
///
/// ***
Expand Down
2 changes: 0 additions & 2 deletions Workflow/Sources/WorkflowNode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
* limitations under the License.
*/

import ReactiveSwift

/// Manages a running workflow.
final class WorkflowNode<WorkflowType: Workflow> {
/// Holds the current state of the workflow
Expand Down
2 changes: 0 additions & 2 deletions Workflow/Tests/WorkflowNodeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
import XCTest
@testable import Workflow

import ReactiveSwift

final class WorkflowNodeTests: XCTestCase {
func test_rendersSimpleWorkflow() {
let node = WorkflowNode(workflow: SimpleWorkflow(string: "Foo"))
Expand Down