Skip to content

[fix]: minor storage lifetime optimization #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[fix]: minor storage lifetime optimization #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Workflow/Sources/AnyWorkflow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,18 @@ extension AnyWorkflow {
return AnyWorkflow<Rendering, NewOutput>.Storage<T>(
workflow: workflow,
renderingTransform: renderingTransform,
outputTransform: { transform(self.outputTransform($0)) }
outputTransform: { [outputTransform] in
transform(outputTransform($0))
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the common use case, you have things like:

MyWorkflow()
  .asAnyWorkflow()  // creates internal storage
  .mapOutput { ... }  // creates new internal storage & would previously hold a reference to old storage
  .rendered(...)

now we won't keep the storage instances around longer than necessary.

)
}

override func mapRendering<NewRendering>(transform: @escaping (Rendering) -> NewRendering) -> AnyWorkflow<NewRendering, Output>.AnyStorage {
return AnyWorkflow<NewRendering, Output>.Storage<T>(
workflow: workflow,
renderingTransform: { transform(self.renderingTransform($0)) },
renderingTransform: { [renderingTransform] in
transform(renderingTransform($0))
},
outputTransform: outputTransform
)
}
Expand Down