[task]: attempt to improve debugging info for AnyWorkflowAction #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorde
reviewed
Mar 14, 2023
| fileID: StaticString = #fileID, | ||
| line: UInt = #line | ||
| ) { | ||
| let closureAction = ClosureAction<WorkflowType>( |
There was a problem hiding this comment.
could we expose a way for consumers who receive AnyWorkflowAction to know if this is wrapping a closure vs. a real action? could maybe make ClosureAction public to achieve that
let action: AnyWorkflowAction<SomeWorkflow> = ...
if action.base is ClosureAction<SomeWorkflow> {
}
There was a problem hiding this comment.
yeah we can do that. do you think full access to the underlying type is needed? or would a flag suffice?
There was a problem hiding this comment.
In general my default is "provide more access" but I know as the SDK author its the opposite for you :p for now I suppose a flag would work
jamieQ
changed the title
mjohnson12
approved these changes
Mar 16, 2023
amorde
approved these changes
Mar 17, 2023
amorde
reviewed
Mar 17, 2023
| /// defined via a closure. | ||
| struct ClosureAction<WorkflowType: Workflow>: WorkflowAction { | ||
| private let _apply: (inout WorkflowType.State) -> WorkflowType.Output? | ||
| let fileID: StaticString |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this change adds introspection capabilities for what i believe is the final type-eraser that lacks them – AnyWorkflowAction. changes include:
baseproperty onAnyWorkflowActionto expose the underlying action as anAnyvalueClosureAction, for closure-basedAnyWorkflowActions. the intent is to provide the possibility of improved telemetry information when logging such actions.isClosureBasedonAnyWorkflowActionto differentiate instances that forward to an underlying wrapped action vs those whose implementations are defined by a closure.Checklist