Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feat]: add ViewEnvironmentUI module #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: add ViewEnvironmentUI module #205
Changes from 6 commits
6eacf4a
7b7c59f
593250d
b37dad6
3c9c384
6efa11a
117963c
ceac6b7
7fdbe94
c1241f6
2284751
8d4478f
6802cb5
f552eb5
d918d9a
8386ed7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, orthogonal to this change: Do the customizations in
self.customize(environment:)
affect the value passed toself.apply(environment:)
, or only to decendants'apply(environment:)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customizations currently apply to the environment on the node itself. I'll clarify this in documentation.
Andrew mentioned that this was surprising during his review and I have a note to follow up on this. Which shape is most intuitive to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I did guess correctly that customizations do apply to self, but I was on the fence about it.
Applying customizations to descendants only would be sensible in that the node can easily opt into applying the same customizations to itself within
self.apply(environment:)
. But if nodes almost always want that, then maybe it's annoying to have to startapply(environment:)
with