[fix]: add render context validation check to makeSink #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
the
makeSink(...)
method of the concreteRenderContext
implementation did not include the same validation assertion that all other methods of the type have. this could lead to issues where a context was retained outside of arender(...)
method and if it was used to make a sink outside that method, we would not detect that unexpected state.Description
assertStillValid
check to themakeSink
methodnote: personally i think we should aim to go a bit further and make the validation assertion a precondition as well as destroy the reference to the internal context when the externally-accessible context is invalidated. but that sort of change likely requires gathering some data about places that might currently break if we were to fail more 'aggressively' in that scenario.
Checklist