Removed unnecessary nested generic type #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabs-m
approved these changes
Feb 13, 2024
jamieQ
reviewed
Feb 13, 2024
mjohnson12
force-pushed
the
markj/fix_nested_generic_type_warning
branch
from
1246db7 to
e1a3f0b
Compare
mjohnson12
changed the title
jamieQ
approved these changes
Feb 13, 2024
ExpectedSideEffect had a unnecessary WorkflowType that was shadowing the outer WorkflowType type.
mjohnson12
force-pushed
the
markj/fix_nested_generic_type_warning
branch
from
e1a3f0b to
6d77614
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested type ExpectedSideEffect was using the same name for the workflow generic type as the outer type RenderTester. This created a shadowed type name warning.
Removing the generic type got rid of the warning
Checklist