Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty workflowDidChange from Xcode project templates #314

Merged

Conversation

blakemcanally
Copy link
Contributor

@blakemcanally blakemcanally commented Nov 14, 2024

Remove the empty workflowDidChange(from previousWorkflow:state:) method from Xcode project templates and tests.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@blakemcanally blakemcanally marked this pull request as ready for review November 14, 2024 19:24
@blakemcanally blakemcanally requested a review from a team as a code owner November 14, 2024 19:24
Copy link
Contributor

@jamieQ jamieQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're in here, would you mind seeing if we can remove this one as well? seems like it is redundant since we have a blanket default implementation (though i haven't personally tried compiling it).

@blakemcanally blakemcanally force-pushed the mcanally/omit_empty_workflowDidChange branch from 42c57c0 to c908fda Compare November 15, 2024 02:33
@blakemcanally
Copy link
Contributor Author

while you're in here, would you mind seeing if we can remove this one as well? seems like it is redundant since we have a blanket default implementation (though i haven't personally tried compiling it).

updated! lets see how CI likes it

@jamieQ
Copy link
Contributor

jamieQ commented Mar 12, 2025

@blakemcanally want to re-kick CI on this one somehow and see if we can get it merged when you have a moment? or maybe i can do that in some manner?

@blakemcanally blakemcanally force-pushed the mcanally/omit_empty_workflowDidChange branch from c908fda to e24740b Compare March 12, 2025 03:19
@jamieQ jamieQ enabled auto-merge (squash) March 12, 2025 03:22
@jamieQ jamieQ merged commit b55d41b into square:main Mar 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants