Rename expect(worker:producingOutput:) to be more clear about what it is asserting
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jamieQ
reviewed
Apr 3, 2025
amayers
force-pushed
the
amayers/worker_expect
branch
from
a5f5592 to
9655f00
Compare
jamieQ
reviewed
Apr 7, 2025
amayers
force-pushed
the
amayers/worker_expect
branch
2 times, most recently
from
216f44b to
f4aa789
Compare
When I first saw tests that used this function, I thought it was asserting that the `worker` passed in, matches the `workflow.worker` (which it does do), but then I thought it was asserting that `producingOutput == workflow.worker.output` (which it does NOT do). Instead, neither of the workers are ever run. The `producingOutput` is used as mock output. So renaming these to make it more clear what is going on.
amayers
force-pushed
the
amayers/worker_expect
branch
from
f4aa789 to
3cc04e0
Compare
jamieQ
approved these changes
Apr 8, 2025
mjohnson12
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first saw tests that used this function, I thought it was asserting that the
workerpassed in, matches theworkflow.worker(which it does do), and that it was asserting thatproducingOutput == workflow.worker.output(which it does NOT do). Instead, neither of the workers are ever run. TheproducingOutputis used as mock output. So renaming these to make it more clear what is going on.Checklist