[gardening]: remove unneeded code from ChildKey #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
commented
Mar 11, 2025
Comment on lines
-415
to
-423
| func hash(into hasher: inout Hasher) { | ||
| hasher.combine(ObjectIdentifier(childType)) | ||
| hasher.combine(key) | ||
| } | ||
|
|
||
| static func == (lhs: ChildKey, rhs: ChildKey) -> Bool { | ||
| lhs.childType == rhs.childType | ||
| && lhs.key == rhs.key | ||
| } |
There was a problem hiding this comment.
we get these for free if all our stored properties are Hashable
There was a problem hiding this comment.
you may find this wrapper useful to do the same thing with better debugging/logging
mjohnson12
approved these changes
Mar 12, 2025
kyleve
approved these changes
Mar 12, 2025
watt
approved these changes
Mar 12, 2025
Comment on lines
-415
to
-423
| func hash(into hasher: inout Hasher) { | ||
| hasher.combine(ObjectIdentifier(childType)) | ||
| hasher.combine(key) | ||
| } | ||
|
|
||
| static func == (lhs: ChildKey, rhs: ChildKey) -> Bool { | ||
| lhs.childType == rhs.childType | ||
| && lhs.key == rhs.key | ||
| } |
There was a problem hiding this comment.
you may find this wrapper useful to do the same thing with better debugging/logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small refactor of
ChildKeyto remove customHashablerequirement implementations in favor of synthesized ones