[refactor]: introduce a 'HostContext' for exposing host info through tree #325
+108
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
changed the title
jamieQ
commented
Mar 12, 2025
| @@ -194,7 +202,7 @@ extension WorkflowNode.SubtreeManager { | |||
| let eventPipe = EventPipe() | |||
| eventPipes.append(eventPipe) | |||
|
|
|||
| /// See if we can | |||
| /// See if we can reuse an existing child node for the given key. | |||
There was a problem hiding this comment.
this truncated sentence has bothered me for a long time – i think this is probably what it was going to
mjohnson12
approved these changes
Mar 12, 2025
kyleve
approved these changes
Mar 12, 2025
watt
approved these changes
Mar 12, 2025
|
|
||
| /// A context object to expose certain root-level information to each node | ||
| /// in the Workflow tree. | ||
| final class HostContext { |
There was a problem hiding this comment.
sorry, are you asking why is it a class? assuming 'yes', then it's because i think we will eventually want to allow different parts of the tree to be able to mutate some of its properties and have those changes be visible elsewhere. e.g. you're handling an action and want to remember that 'some node in the tree was invalidated' by the time the root/host has to do the next render.
jamieQ
force-pushed
the
jquadri/host-context
branch
from
0703d92 to
1355990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostContexttype to hold 'host-level' information to be distributed to various entities throughout the workflow treenote: no new tests added as no new functionality introduced yet